Issue 5028 - Use browser namespace

polyfill.js

Index: polyfill.js
===================================================================
new file mode 100644
--- /dev/null
+++ b/polyfill.js
@@ -0,0 +1,21 @@
+/*
+ * This file is part of Adblock Plus <https://adblockplus.org/>,
+ * Copyright (C) 2006-present eyeo GmbH
+ *
+ * Adblock Plus is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 3 as
+ * published by the Free Software Foundation.
+ *
+ * Adblock Plus is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
+ */
+
+"use strict";
+
+if (typeof browser == "undefined")

[Sebastian Noack, 2017/10/10 23:23:08]

This check seems unnecessary. This script is only included when running the
standalone test server within adblockplusui.

[Manish Jethani, 2017/10/11 11:29:06]

But if the developer is testing on Chrome, the browser object won't be available
and consequently they won't be able to test, right?

[Sebastian Noack, 2017/10/13 02:48:17]

The browser object will never be available here, as this code doesn't run in the
context of an extension, but in the context of a web page, when testing
adblockplusui standalone, which is the only case in which this script runs.

[Manish Jethani, 2017/10/13 05:00:34]

Ah, you're right.

Done.

+  window.browser = {};