Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: templates/geckoInfo.js.tmpl

Issue 29573134: Issue 5028 - Use browser namespace (Closed) Base URL: https://hg.adblockplus.org/buildtools/
Patch Set: Created Oct. 10, 2017, 10:53 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chromeDevenvPoller__.js ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* This Source Code Form is subject to the terms of the Mozilla Public 1 /* This Source Code Form is subject to the terms of the Mozilla Public
2 * License, v. 2.0. If a copy of the MPL was not distributed with this 2 * License, v. 2.0. If a copy of the MPL was not distributed with this
3 * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ 3 * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
4 4
5 "use strict"; 5 "use strict";
6 6
7 exports.addonName = {{ basename|json }}; 7 exports.addonName = {{ basename|json }};
8 exports.addonVersion = {{ version|json }}; 8 exports.addonVersion = {{ version|json }};
9 9
10 exports.application = "unknown"; 10 exports.application = "unknown";
11 exports.applicationVersion = "0"; 11 exports.applicationVersion = "0";
12 12
13 exports.platform = "gecko"; 13 exports.platform = "gecko";
14 exports.platformVersion = "0"; 14 exports.platformVersion = "0";
15 15
16 let match = /\brv:(\d+(?:\.\d+)?)\b/.exec(navigator.userAgent); 16 let match = /\brv:(\d+(?:\.\d+)?)\b/.exec(navigator.userAgent);
17 if (match) 17 if (match)
18 exports.platformVersion = match[1]; 18 exports.platformVersion = match[1];
19 19
20 // Firefox 50 does not support runtime.getBrowserInfo 20 // Firefox 50 does not support runtime.getBrowserInfo
21 if ("getBrowserInfo" in browser.runtime) 21 if ("getBrowserInfo" in browser.runtime)
22 { 22 {
23 browser.runtime.getBrowserInfo().then(browserInfo => 23 browser.runtime.getBrowserInfo(browserInfo =>
Sebastian Noack 2017/10/10 23:12:19 This shouldn't be necessary. I think, we should no
Manish Jethani 2017/10/11 11:33:27 Done.
24 { 24 {
25 exports.application = browserInfo.name.toLowerCase(); 25 exports.application = browserInfo.name.toLowerCase();
26 exports.applicationVersion = browserInfo.version; 26 exports.applicationVersion = browserInfo.version;
27 }); 27 });
28 } 28 }
29 else 29 else
30 { 30 {
31 let browserInfo = /\bFirefox\/(\S+)/.exec(navigator.userAgent); 31 let browserInfo = /\bFirefox\/(\S+)/.exec(navigator.userAgent);
32 exports.application = "firefox"; 32 exports.application = "firefox";
33 if (browserInfo) 33 if (browserInfo)
34 exports.applicationVersion = browserInfo[1]; 34 exports.applicationVersion = browserInfo[1];
35 } 35 }
OLDNEW
« no previous file with comments | « chromeDevenvPoller__.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld