Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: lib/options.js

Issue 29573801: Issue 4580 - Replace ext.getURL with extension.getURL (Closed) Base URL: https://hg.adblockplus.org/adblockpluschrome/
Patch Set: Created Oct. 11, 2017, 4:15 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/notificationHelper.js ('k') | lib/subscriptionInit.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/options.js
===================================================================
--- a/lib/options.js
+++ b/lib/options.js
@@ -32,17 +32,17 @@
{
// We find a tab ourselves because Edge has a bug when quering tabs with
// extension URL protocol:
// https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/8094141/
// https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/8604703/
// Firefox won't let us query for moz-extension:// pages either, though
// starting with Firefox 56 an extension can query for its own URLs:
// https://bugzilla.mozilla.org/show_bug.cgi?id=1271354
- let fullOptionsUrl = ext.getURL(optionsUrl);
+ let fullOptionsUrl = chrome.extension.getURL(optionsUrl);
callback(tabs.find(element => element.url == fullOptionsUrl));
});
}
function returnShowOptionsCall(optionsTab, callback)
{
if (!callback)
return;
« no previous file with comments | « lib/notificationHelper.js ('k') | lib/subscriptionInit.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld