Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(777)

Issue 29573912: Issue 5857 - Retry npm install on failure (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 months ago by tlucas
Modified:
2 months ago
Reviewers:
Sebastian Noack, kzar
CC:
Vasily Kuznetsov, Wladimir Palant
Visibility:
Public.

Description

Issue 5857 - Retry npm install on failure

Patch Set 1 #

Total comments: 6
Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -1 line) Patch
M ensure_dependencies.py View 3 chunks +12 lines, -1 line 6 comments Download

Messages

Total messages: 7
tlucas
Patch Set 1 Let ensure_dependencies.py retry `npm install` after it previously failed.
2 months ago (2017-10-11 22:51:08 UTC) #1
Sebastian Noack
https://codereview.adblockplus.org/29573912/diff/29573913/ensure_dependencies.py File ensure_dependencies.py (right): https://codereview.adblockplus.org/29573912/diff/29573913/ensure_dependencies.py#newcode47 ensure_dependencies.py:47: NPM_LOCKFILE = '.npm_install_lock' This file would have to be ...
2 months ago (2017-10-11 23:22:33 UTC) #2
tlucas
https://codereview.adblockplus.org/29573912/diff/29573913/ensure_dependencies.py File ensure_dependencies.py (right): https://codereview.adblockplus.org/29573912/diff/29573913/ensure_dependencies.py#newcode47 ensure_dependencies.py:47: NPM_LOCKFILE = '.npm_install_lock' On 2017/10/11 23:22:33, Sebastian Noack wrote: ...
2 months ago (2017-10-11 23:48:55 UTC) #3
Sebastian Noack
https://codereview.adblockplus.org/29573912/diff/29573913/ensure_dependencies.py File ensure_dependencies.py (right): https://codereview.adblockplus.org/29573912/diff/29573913/ensure_dependencies.py#newcode47 ensure_dependencies.py:47: NPM_LOCKFILE = '.npm_install_lock' On 2017/10/11 23:48:55, tlucas wrote: > ...
2 months ago (2017-10-12 00:08:00 UTC) #4
kzar
LGTM https://codereview.adblockplus.org/29573912/diff/29573913/ensure_dependencies.py File ensure_dependencies.py (right): https://codereview.adblockplus.org/29573912/diff/29573913/ensure_dependencies.py#newcode284 ensure_dependencies.py:284: repo_types[vcs].ignore(os.path.join(target, NPM_LOCKFILE), target) I wonder if we should ...
2 months ago (2017-10-13 10:14:23 UTC) #5
tlucas
https://codereview.adblockplus.org/29573912/diff/29573913/ensure_dependencies.py File ensure_dependencies.py (right): https://codereview.adblockplus.org/29573912/diff/29573913/ensure_dependencies.py#newcode284 ensure_dependencies.py:284: repo_types[vcs].ignore(os.path.join(target, NPM_LOCKFILE), target) On 2017/10/13 10:14:23, kzar wrote: > ...
2 months ago (2017-10-13 10:31:36 UTC) #6
kzar
2 months ago (2017-10-13 11:20:42 UTC) #7
Message was sent while issue was closed.
https://codereview.adblockplus.org/29573912/diff/29573913/ensure_dependencies.py
File ensure_dependencies.py (right):

https://codereview.adblockplus.org/29573912/diff/29573913/ensure_dependencies...
ensure_dependencies.py:284: repo_types[vcs].ignore(os.path.join(target,
NPM_LOCKFILE), target)
On 2017/10/13 10:31:36, tlucas wrote:
> On 2017/10/13 10:14:23, kzar wrote:
> > I wonder if we should just ignore this file consistently, since we never
> > un-ignore it again anyway?
> 
> This file should - in a best case scenario - never remain. IMHO an entry in
> .gitignore / .hgignore would only confuse people, if it never is created.

Yea, fair enough.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5