Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code
Issues
All Issues

Delta Between Two Patch Sets: pages/modules.html

Issue 29573947: Noissue - Restructure Build-and-Release-Tools and Sitescripts modules (Closed)
Left Patch Set: Created Oct. 12, 2017, 2:45 a.m.
Right Patch Set: Added description Created Oct. 20, 2017, 1:51 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « no previous file | no next file » | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 title=Modules 1 title=Modules
2 2
3 <head> 3 <head>
4 <style type="text/css"> 4 <style type="text/css">
5 table 5 table
6 { 6 {
7 background: white; 7 background: white;
8 border-collapse: collapse; 8 border-collapse: collapse;
9 margin-top: 20px; 9 margin-top: 20px;
10 } 10 }
(...skipping 47 matching lines...) Expand 10 before | Expand all | Expand 10 after
58 </tr> 58 </tr>
59 </table> 59 </table>
60 60
61 <table id="user-interface"> 61 <table id="user-interface">
62 <tr> 62 <tr>
63 <th>{{table-header-name Name}}</th> 63 <th>{{table-header-name Name}}</th>
64 <td>User Interface</td> 64 <td>User Interface</td>
65 </tr> 65 </tr>
66 <tr> 66 <tr>
67 <th>{{table-header-description Description}}</th> 67 <th>{{table-header-description Description}}</th>
68 <td>{{module-ui-description The shared UI code.}}</td> 68 <td>{{module-ui-description The User Interface of the Adblock Plus browser e xtension.}}</td>
Sebastian Noack 2017/10/20 01:53:38 While on it, I also fixed this description, since
kzar 2017/10/20 11:48:13 Fair enough, but Thomas should check this change t
Thomas Greiner 2017/10/20 14:38:12 I'm ok with this change.
69 </tr> 69 </tr>
70 <tr> 70 <tr>
71 <th>{{table-header-owner Owner}}</th> 71 <th>{{table-header-owner Owner}}</th>
72 <td><a href="mailto:thomas@adblockplus.org">Thomas Greiner</a></td> 72 <td><a href="mailto:thomas@adblockplus.org">Thomas Greiner</a></td>
73 </tr> 73 </tr>
74 <tr> 74 <tr>
75 <th>{{table-header-peers Peer(s)}}</th> 75 <th>{{table-header-peers Peer(s)}}</th>
76 <td><a href="mailto:manvel@adblockplus.org">Manvel Saroyan</a></td> 76 <td><a href="mailto:manvel@adblockplus.org">Manvel Saroyan</a></td>
77 </tr> 77 </tr>
78 <tr> 78 <tr>
(...skipping 49 matching lines...) Expand 10 before | Expand all | Expand 10 after
128 {{module-platform-source <a href="https://hg.adblockplus.org/adblockpl uschrome"><fix>adblockpluschrome</fix></a> (except <a href="#user-interface"><fi x>User Interface</fix></a>)}} 128 {{module-platform-source <a href="https://hg.adblockplus.org/adblockpl uschrome"><fix>adblockpluschrome</fix></a> (except <a href="#user-interface"><fi x>User Interface</fix></a>)}}
129 </li> 129 </li>
130 <li> 130 <li>
131 <a href="https://hg.adblockplus.org/abp2blocklist">abp2blocklist</a> 131 <a href="https://hg.adblockplus.org/abp2blocklist">abp2blocklist</a>
132 </li> 132 </li>
133 </ul> 133 </ul>
134 </td> 134 </td>
135 </tr> 135 </tr>
136 </table> 136 </table>
137 137
138 <table id="tooling"> 138 <table id="automation">
139 <tr> 139 <tr>
140 <th>{{table-header-name Name}}</th> 140 <th>{{table-header-name Name}}</th>
141 <td>Tooling</td> 141 <td>Automation</td>
Sebastian Noack 2017/10/12 03:20:36 This name isn't final, but rather a working title.
kzar 2017/10/12 09:10:48 I don't like this name much, but I can't think of
tlucas 2017/10/13 16:35:42 FWIW, i personally prefer the "Automation" suggest
Sebastian Noack 2017/10/13 20:01:56 Done.
142 </tr>
143 <tr>
144 <th>{{table-header-description Description}}</th>
145 <td>{{module-automation-description The build and release automation for the Adblock Plus browser extension, and some general coding tools.}}</td>
142 </tr> 146 </tr>
143 <tr> 147 <tr>
144 <th>{{table-header-owner Owner}}</th> 148 <th>{{table-header-owner Owner}}</th>
145 <td><a href="mailto:sebastian@adblockplus.org">Sebastian Noack</a></td> 149 <td><a href="mailto:sebastian@adblockplus.org">Sebastian Noack</a></td>
146 </tr> 150 </tr>
147 <tr> 151 <tr>
148 <th>{{table-header-peers Peer(s)}}</th> 152 <th>{{table-header-peers Peer(s)}}</th>
149 <td><a href="mailto:tristan@adblockplus.org">Tristan Lucas</a></td> 153 <td><a href="mailto:tristan@adblockplus.org">Tristan Lucas</a></td>
150 </tr> 154 </tr>
151 <tr> 155 <tr>
(...skipping 337 matching lines...) Expand 10 before | Expand all | Expand 10 after
489 <li> 493 <li>
490 <a href="https://hg.adblockplus.org/abpbot">abpbot</a> 494 <a href="https://hg.adblockplus.org/abpbot">abpbot</a>
491 </li> 495 </li>
492 <li> 496 <li>
493 <a href="https://hg.adblockplus.org/cms">cms</a> 497 <a href="https://hg.adblockplus.org/cms">cms</a>
494 </li> 498 </li>
495 <li> 499 <li>
496 <a href="https://hg.adblockplus.org/python-abp">python-abp</a> 500 <a href="https://hg.adblockplus.org/python-abp">python-abp</a>
497 </li> 501 </li>
498 <li> 502 <li>
499 {{module-sitescripts-source <a href="https://hg.adblockplus.org/sitesc ripts"><fix>sitescripts</fix></a> (except <a href="#tooling"><fix>Tooling</fix>< /a>)}} 503 {{module-sitescripts-source <a href="https://hg.adblockplus.org/sitesc ripts"><fix>sitescripts</fix></a> (except <a href="#automation"><fix>Automation< /fix></a>)}}
Vasily Kuznetsov 2017/10/12 12:14:35 Redirecting to Tooling to understand which part of
Sebastian Noack 2017/10/12 22:28:09 I did it consistently with how Platform and User I
Vasily Kuznetsov 2017/10/13 09:44:01 Acknowledged.
500 </li> 504 </li>
501 </ul> 505 </ul>
502 </td> 506 </td>
503 </tr> 507 </tr>
504 </table> 508 </table>
505 509
506 <table id="extensions-for-adblock-plus"> 510 <table id="extensions-for-adblock-plus">
507 <tr> 511 <tr>
508 <th>{{table-header-name Name}}</th> 512 <th>{{table-header-name Name}}</th>
509 <td>Extensions for Adblock Plus</td> 513 <td>Extensions for Adblock Plus</td>
(...skipping 83 matching lines...) Expand 10 before | Expand all | Expand 10 after
593 <th>{{table-header-source-path Source path(s)}}</th> 597 <th>{{table-header-source-path Source path(s)}}</th>
594 <td> 598 <td>
595 <ul> 599 <ul>
596 <li> 600 <li>
597 <a href="https://hg.adblockplus.org/urlfixer">urlfixer</a> 601 <a href="https://hg.adblockplus.org/urlfixer">urlfixer</a>
598 </li> 602 </li>
599 </ul> 603 </ul>
600 </td> 604 </td>
601 </tr> 605 </tr>
602 </table> 606 </table>
LEFTRIGHT
« no previous file | no next file » | Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Toggle Comments ('s')

Powered by Google App Engine
This is Rietveld