Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: pages/modules.html

Issue 29573947: Noissue - Restructure Build-and-Release-Tools and Sitescripts modules (Closed)
Patch Set: Created Oct. 12, 2017, 2:45 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pages/modules.html
===================================================================
--- a/pages/modules.html
+++ b/pages/modules.html
@@ -135,21 +135,18 @@
</tr>
</table>
-<table id="build-and-release-tools">
+<table id="tooling">
<tr>
<th>{{table-header-name Name}}</th>
- <td>Build and Release Tools</td>
+ <td>Tooling</td>
Sebastian Noack 2017/10/12 03:20:36 This name isn't final, but rather a working title.
kzar 2017/10/12 09:10:48 I don't like this name much, but I can't think of
tlucas 2017/10/13 16:35:42 FWIW, i personally prefer the "Automation" suggest
Sebastian Noack 2017/10/13 20:01:56 Done.
</tr>
<tr>
<th>{{table-header-owner Owner}}</th>
<td><a href="mailto:sebastian@adblockplus.org">Sebastian Noack</a></td>
</tr>
<tr>
- <th rowspan="2">{{table-header-peers Peer(s)}}</th>
- <td><a href="mailto:dave@adblockplus.org">Dave Barker</a></td>
Sebastian Noack 2017/10/12 03:20:36 Dave, let me know if you would want to be a module
kzar 2017/10/12 09:10:48 I don't mind, I think I can still add something bu
Sebastian Noack 2017/10/12 22:28:09 If you want to request improvements, just file iss
- </tr>
- <tr>
- <td><a href="mailto:vasily@adblockplus.org">Vasily Kuznetsov</a></td>
+ <th>{{table-header-peers Peer(s)}}</th>
+ <td><a href="mailto:tristan@adblockplus.org">Tristan Lucas</a></td>
</tr>
<tr>
<th>{{table-header-super-reviewer Super reviewer}}</th>
@@ -163,7 +160,13 @@
<a href="https://hg.adblockplus.org/buildtools">buildtools</a>
</li>
<li>
- <a href="https://hg.adblockplus.org/screenshotter">screenshotter</a>
Sebastian Noack 2017/10/12 03:20:36 I have no idea what this thing was, but apparently
+ <a href="https://hg.adblockplus.org/codingtools">codingtools</a>
+ </li>
+ <li>
+ <a href="https://hg.adblockplus.org/sitescripts">sitescripts</a>
+ <ul>
+ <li>sitescripts/extensions/*</li>
+ </ul>
</li>
</ul>
</td>
@@ -476,10 +479,6 @@
<td><a href="mailto:vasily@adblockplus.org">Vasily Kuznetsov</a></td>
</tr>
<tr>
- <th>{{table-header-peers Peer(s)}}</th>
- <td><a href="mailto:sebastian@adblockplus.org">Sebastian Noack</a></td>
- </tr>
- <tr>
<th>{{table-header-super-reviewer Super reviewer}}</th>
<td><a href="mailto:felix@adblockplus.org">Felix Dahlke</a></td>
</tr>
@@ -494,13 +493,10 @@
<a href="https://hg.adblockplus.org/cms">cms</a>
</li>
<li>
- <a href="https://hg.adblockplus.org/codingtools">codingtools</a>
- </li>
- <li>
<a href="https://hg.adblockplus.org/python-abp">python-abp</a>
</li>
<li>
- <a href="https://hg.adblockplus.org/sitescripts">sitescripts</a>
+ {{module-sitescripts-source <a href="https://hg.adblockplus.org/sitescripts"><fix>sitescripts</fix></a> (except <a href="#tooling"><fix>Tooling</fix></a>)}}
Vasily Kuznetsov 2017/10/12 12:14:35 Redirecting to Tooling to understand which part of
Sebastian Noack 2017/10/12 22:28:09 I did it consistently with how Platform and User I
Vasily Kuznetsov 2017/10/13 09:44:01 Acknowledged.
</li>
</ul>
</td>
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld