.gitignore - Issue 29574577: Issue 5856 - Pass --no-package-lock argument to npm install

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: .gitignore

Issue 29574577: Issue 5856 - Pass --no-package-lock argument to npm install (Closed)

Patch Set: Created Oct. 12, 2017, 11:35 a.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View unified diff | Download patch

OLD	NEW
1 *.pyc	1 *.pyc

2 *.pyo	2 *.pyo

3 /.tox	3 /.tox

	4 /package-lock.json
	tlucas 2017/10/12 12:01:59 I don't think this should be necessary - after all I don't think this should be necessary - after all, we won't create any package-lock.json in the future... For the time being, since there are now untracked package-lock.json files due to https://hg.adblockplus.org/buildtools/rev/e9059b211107 , i'd rather delete them manually instead of ignoring them (Maybe with an integration note in #5856) IIRC, this only happend in adblockpluschrome and adblockplusui - so one would only have to manually delete the untracked files from ./adblockplusui/buildtools ./buildtools (No guarantee here though) ... what do you think? tlucas 2017/10/12 12:28:13 I just noticed your explanation in the ticket, i.e Show quoted text On 2017/10/12 12:01:59, tlucas wrote: > I don't think this should be necessary - after all, we won't create any > package-lock.json in the future... > > For the time being, since there are now untracked package-lock.json files due to > https://hg.adblockplus.org/buildtools/rev/e9059b211107 , i'd rather delete them > manually instead of ignoring them (Maybe with an integration note in #5856) > > IIRC, this only happend in adblockpluschrome and adblockplusui - so one would > only have to manually delete the untracked files from > > ./adblockplusui/buildtools > ./buildtools > > (No guarantee here though) > > > ... what do you think? I just noticed your explanation in the ticket, i.e. why you wanted to add this. IMHO it should never be necessary to manually run 'npm install' (or at least we should make sure that there is no necessity to ever do so). On the other hand, if the user runs 'npm install' and creates a package-lock.json, the notification about a new unstaged file could possibly prevent an existing package-lock.json to somehow (not sure in what way though, but i got somehow cautious about this yesterday) mess up an npm installation. If neither git, nor hg warned about this new file, one could easily overlook this... kzar 2017/10/12 13:20:12 Yea good point, I think I agree. Done. Show quoted text On 2017/10/12 12:28:13, tlucas wrote: > On 2017/10/12 12:01:59, tlucas wrote: > > I don't think this should be necessary - after all, we won't create any > > package-lock.json in the future... > > > > For the time being, since there are now untracked package-lock.json files due > to > > https://hg.adblockplus.org/buildtools/rev/e9059b211107 , i'd rather delete > them > > manually instead of ignoring them (Maybe with an integration note in #5856) > > > > IIRC, this only happend in adblockpluschrome and adblockplusui - so one would > > only have to manually delete the untracked files from > > > > ./adblockplusui/buildtools > > ./buildtools > > > > (No guarantee here though) > > > > > > ... what do you think? > > I just noticed your explanation in the ticket, i.e. why you wanted to add this. > IMHO it should never be necessary to manually run 'npm install' (or at least we > should make sure that there is no necessity to ever do so). > > On the other hand, if the user runs 'npm install' and creates a > package-lock.json, the notification about a new unstaged file could possibly > prevent an existing package-lock.json to somehow (not sure in what way though, > but i got somehow cautious about this yesterday) mess up an npm installation. If > neither git, nor hg warned about this new file, one could easily overlook > this... Yea good point, I think I agree. Done.
OLD	NEW

« no previous file with comments | « no previous file | .hgignore » ('j') | .hgignore » ('J')