Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Keyboard Shortcuts
File
u
:
up to issue
m
:
publish + mail comments
M
:
edit review message
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
<Enter>
:
respond to / edit current comment
d
:
mark current comment as done
Issue
u
:
up to list of issues
m
:
publish + mail comments
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
#
:
close issue
Comment/message editing
<Ctrl>
+
s
or
<Ctrl>
+
Enter
:
save comment
<Esc>
:
cancel edit
Rietveld
Code Review Tool
Help
|
Bug tracker
|
Discussion group
|
Source code
Issues
All Issues
Side by Side Diff: info.js
Issue
29574582
:
Issue 5535 - Replace our module system with webpack (Closed)
Patch Set: Avoid both mapping and bundling the same file
Created Oct. 12, 2017, 6:01 p.m.
Left:
Base
Patch Set 1: None
Patch Set 2: Avoid both mapping and bundling the same file
Patch Set 3: Addressed nit
Right:
Patch Set 1: None
Patch Set 2: Avoid both mapping and bundling the same file
Patch Set 3: Addressed nit
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
info.js
info-loader.js
package.json
packagerChrome.py
packagerEdge.py
templates/modules.js.tmpl
webpack_runner.js
View unified diff
|
Download patch
« no previous file with comments
|
« no previous file
|
info-loader.js »
('j') |
packagerChrome.py »
('J')
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
/* This file is required to exist by webpack, but its contents are ignored! */
OLD
NEW
« no previous file with comments
|
« no previous file
|
info-loader.js »
('j') |
packagerChrome.py »
('J')
Edit Message
Issue 29574582: Issue 5535 - Replace our module system with webpack (Closed)
Created Oct. 12, 2017, 11:53 a.m. by kzar
Modified Oct. 15, 2017, 1:11 p.m.
Reviewers: Sebastian Noack, tlucas
Base URL:
Comments: 3
+ 1 drafts
This is Rietveld