Issue 5535 - Replace our module system with webpack

webpack_runner.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 114 matching lines @@
     {
       let reason = err.stack || err;
       if (err.details)
         reason += "\n" + err.details;
       throw new Error(reason);
     }
     else if (stats.hasErrors())
       throw new Error(stats.toJson().errors.join("\n"));
     else
     {
-      let files = {};
+      let output = {};
+      let files = output.files = {};
 
       for (let config of options)
       {
         let filepath = path.join(config.output.path, config.output.filename);
         let relativeFilepath = path.relative("/", filepath);

[kzar, 2017/10/12 11:57:28]

These few lines are the only difference from the previous review (except for
being rebased e.g. the omitted package-lock.json) file. See
https://issues.adblockplus.org/ticket/5535 and
https://codereview.adblockplus.org/29573821/ for more context.

         files[relativeFilepath] = memoryFS.readFileSync(filepath, "utf-8");
         files[relativeFilepath + ".map"] = memoryFS.readFileSync(
           filepath + ".map", "utf-8"
         );
       }
 
-      console.log(JSON.stringify(files));
+      // We provide a list of all the bundled files, so the packager can avoid
+      // including them again outside of a bundle. Otherwise we end up including
+      // duplicate copies in our builds.
+      let included = new Set();
+      for (let bundle of stats.toJson().children)
+      {
+        for (let chunk of bundle.chunks)
+        {
+          for (let module of chunk.modules)
+          {
+            if (!module.name.startsWith("multi "))
+              included.add(path.relative(extension_path, module.name));
+          }
+        }
+      }
+      output.included = Array.from(included);
+
+      console.log(JSON.stringify(output));
     }
   });
 });