Issue 5535 - Replace our module system with webpack

packagerChrome.py

 # This Source Code Form is subject to the terms of the Mozilla Public
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
 
 import errno
 import glob
 import io
 import json
 import os
 import re
@@ skipping 181 matching lines @@
     process = subprocess.Popen(cmd, stdout=subprocess.PIPE,
                                stdin=subprocess.PIPE)
     output = process.communicate(input=toJson(configuration))[0]
     if process.returncode != 0:
         raise subprocess.CalledProcessError(process.returncode, cmd=cmd)
     output = json.loads(output)
 
     # Clear the mapping for any files included in a bundle, to avoid them being
     # duplicated in the build.
     for to_ignore in output['included']:
-        if to_ignore in files:
-            del files[to_ignore]

[Sebastian Noack, 2017/10/12 23:23:28]

You can use files.pop(to_ignore, None), then you don't need to check whether the
file exists first. In which case would we get a filename here that doesn't
exist, anyway?

[kzar, 2017/10/13 07:25:21]

Yea we can do it that way too, Done.

+        files.pop(to_ignore, None)
 
     for bundle in output['files']:
         files[bundle] = output['files'][bundle].encode('utf-8')
 
 
 def import_locales(params, files):
     for item in params['metadata'].items('import_locales'):
         filename, keys = item
         for sourceFile in glob.glob(os.path.join(os.path.dirname(item.source),
                                                  *filename.split('/'))):
@@ skipping 160 matching lines @@
                 params, 'testIndex.html.tmpl', ('general', 'testScripts')
             )
 
     zipdata = files.zipToString()
     signature = None
     pubkey = None
     if keyFile != None:
         signature = signBinary(zipdata, keyFile)
         pubkey = getPublicKey(keyFile)
     writePackage(outFile, pubkey, signature, zipdata)