Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: compiled/filter/CommentFilter.h

Issue 29574591: Issue 5258 - Implement Filter::As<>() method to make working with filters easier from C++ code (Closed) Base URL: https://hg.adblockplus.org/adblockpluscore
Patch Set: Created Oct. 12, 2017, 12:13 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-present eyeo GmbH 3 * Copyright (C) 2006-present eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 * GNU General Public License for more details. 12 * GNU General Public License for more details.
13 * 13 *
14 * You should have received a copy of the GNU General Public License 14 * You should have received a copy of the GNU General Public License
15 * along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>. 15 * along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>.
16 */ 16 */
17 17
18 #pragma once 18 #pragma once
19 19
20 #include "Filter.h" 20 #include "Filter.h"
21 21
22 class CommentFilter : public Filter 22 class CommentFilter : public Filter
23 { 23 {
24 public: 24 public:
25 explicit CommentFilter(const String& text); 25 explicit CommentFilter(const String& text);
26 static Type Parse(const String& text); 26 static Type Parse(const String& text);
27 static CommentFilter* Create(const String& text); 27 static CommentFilter* Create(const String& text);
28 }; 28 };
29
30 template<>
31 inline CommentFilter* Filter::As<CommentFilter>()
32 {
33 if ((mType & Type::COMMENT) == Type::COMMENT)
sergei 2017/10/12 12:24:34 Tests would be very helpful, so far it seems it al
Wladimir Palant 2017/10/13 11:43:28 This is C++ internals, so it cannot be tested dire
34 return nullptr;
35
36 return static_cast<CommentFilter*>(this);
37 }
OLDNEW

Powered by Google App Engine
This is Rietveld