compiled/filter/ActiveFilter.h - Issue 29574591: Issue 5258 - Implement Filter::As<>() method to make working with filters easier from C++ code

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: compiled/filter/ActiveFilter.h

Issue 29574591: Issue 5258 - Implement Filter::As<>() method to make working with filters easier from C++ code (Closed) Base URL: https://hg.adblockplus.org/adblockpluscore

Patch Set: Use static classType member Created Oct. 13, 2017, 11:40 a.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | compiled/filter/BlockingFilter.h » ('j') | compiled/subscription/Subscription.h » ('J')

OLD	NEW
1 /*	1 /*

2 * This file is part of Adblock Plus <https://adblockplus.org/>,	2 * This file is part of Adblock Plus <https://adblockplus.org/>,

3 * Copyright (C) 2006-present eyeo GmbH	3 * Copyright (C) 2006-present eyeo GmbH

4 *	4 *

5 * Adblock Plus is free software: you can redistribute it and/or modify	5 * Adblock Plus is free software: you can redistribute it and/or modify

6 * it under the terms of the GNU General Public License version 3 as	6 * it under the terms of the GNU General Public License version 3 as

7 * published by the Free Software Foundation.	7 * published by the Free Software Foundation.

8 *	8 *

9 * Adblock Plus is distributed in the hope that it will be useful,	9 * Adblock Plus is distributed in the hope that it will be useful,

10 * but WITHOUT ANY WARRANTY; without even the implied warranty of	10 * but WITHOUT ANY WARRANTY; without even the implied warranty of

(...skipping 38 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
49 typedef StringSet SitekeySet;	49 typedef StringSet SitekeySet;

50 void ParseDomains(const String& domains, String::value_type separator) const;	50 void ParseDomains(const String& domains, String::value_type separator) const;

51 void AddSitekey(const String& sitekey) const;	51 void AddSitekey(const String& sitekey) const;

52 virtual DomainMap* GetDomains() const;	52 virtual DomainMap* GetDomains() const;

53 virtual SitekeySet* GetSitekeys() const;	53 virtual SitekeySet* GetSitekeys() const;

54 mutable std::unique_ptr<DomainMap> mDomains;	54 mutable std::unique_ptr<DomainMap> mDomains;

55 mutable std::unique_ptr<SitekeySet> mSitekeys;	55 mutable std::unique_ptr<SitekeySet> mSitekeys;

56 private:	56 private:

57 bool mIgnoreTrailingDot;	57 bool mIgnoreTrailingDot;

58 public:	58 public:

	59 static constexpr Type classType = Type::ACTIVE;

59 explicit ActiveFilter(Type type, const String& text, bool ignoreTrailingDot);	60 explicit ActiveFilter(Type type, const String& text, bool ignoreTrailingDot);

60 FILTER_PROPERTY(bool, mDisabled, FILTER_DISABLED, GetDisabled, SetDisabled);	61 FILTER_PROPERTY(bool, mDisabled, FILTER_DISABLED, GetDisabled, SetDisabled);

61 FILTER_PROPERTY(unsigned int, mHitCount, FILTER_HITCOUNT,	62 FILTER_PROPERTY(unsigned int, mHitCount, FILTER_HITCOUNT,

62 GetHitCount, SetHitCount);	63 GetHitCount, SetHitCount);

63 FILTER_PROPERTY(unsigned int, mLastHit, FILTER_LASTHIT,	64 FILTER_PROPERTY(unsigned int, mLastHit, FILTER_LASTHIT,

64 GetLastHit, SetLastHit);	65 GetLastHit, SetLastHit);

65 bool BINDINGS_EXPORTED IsActiveOnDomain(DependentString& docDomain,	66 bool BINDINGS_EXPORTED IsActiveOnDomain(DependentString& docDomain,

66 const String& sitekey) const;	67 const String& sitekey) const;

67 bool BINDINGS_EXPORTED IsActiveOnlyOnDomain(DependentString& docDomain) const;	68 bool BINDINGS_EXPORTED IsActiveOnlyOnDomain(DependentString& docDomain) const;

68 bool BINDINGS_EXPORTED IsGeneric() const;	69 bool BINDINGS_EXPORTED IsGeneric() const;

69 OwnedString BINDINGS_EXPORTED Serialize() const;	70 OwnedString BINDINGS_EXPORTED Serialize() const;

70 };	71 };

OLD	NEW