Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: compiled/filter/ElemHideBase.h

Issue 29574591: Issue 5258 - Implement Filter::As<>() method to make working with filters easier from C++ code (Closed) Base URL: https://hg.adblockplus.org/adblockpluscore
Left Patch Set: Created Oct. 12, 2017, 12:13 p.m.
Right Patch Set: Removed unnecessary base class check Created Oct. 13, 2017, 4:57 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « compiled/filter/CommentFilter.cpp ('k') | compiled/filter/ElemHideEmulationFilter.h » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-present eyeo GmbH 3 * Copyright (C) 2006-present eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
51 { 51 {
52 return DependentString(text, mSelectorStart); 52 return DependentString(text, mSelectorStart);
53 } 53 }
54 }; 54 };
55 55
56 class ElemHideBase : public ActiveFilter 56 class ElemHideBase : public ActiveFilter
57 { 57 {
58 protected: 58 protected:
59 ElemHideData mData; 59 ElemHideData mData;
60 public: 60 public:
61 static constexpr Type classType = Type::ELEMHIDEBASE;
61 explicit ElemHideBase(Type type, const String& text, const ElemHideData& data) ; 62 explicit ElemHideBase(Type type, const String& text, const ElemHideData& data) ;
62 static Type Parse(DependentString& text, ElemHideData& data); 63 static Type Parse(DependentString& text, ElemHideData& data);
63 64
64 const DependentString BINDINGS_EXPORTED GetSelector() const 65 const DependentString BINDINGS_EXPORTED GetSelector() const
65 { 66 {
66 return mData.GetSelector(mText); 67 return mData.GetSelector(mText);
67 } 68 }
68 69
69 OwnedString BINDINGS_EXPORTED GetSelectorDomain() const; 70 OwnedString BINDINGS_EXPORTED GetSelectorDomain() const;
70 }; 71 };
71
72
73 template<>
74 inline ElemHideBase* Filter::As<ElemHideBase>()
75 {
76 if ((mType & Type::ELEMHIDEBASE) == Type::ELEMHIDEBASE)
77 return nullptr;
78
79 return static_cast<ElemHideBase*>(this);
80 }
LEFTRIGHT

Powered by Google App Engine
This is Rietveld