Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: compiled/filter/Filter.h

Issue 29574591: Issue 5258 - Implement Filter::As<>() method to make working with filters easier from C++ code (Closed) Base URL: https://hg.adblockplus.org/adblockpluscore
Left Patch Set: Created Oct. 12, 2017, 12:13 p.m.
Right Patch Set: Removed unnecessary base class check Created Oct. 13, 2017, 4:57 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « compiled/filter/ElemHideFilter.cpp ('k') | compiled/filter/Filter.cpp » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-present eyeo GmbH 3 * Copyright (C) 2006-present eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
53 const String& BINDINGS_EXPORTED GetText() const 53 const String& BINDINGS_EXPORTED GetText() const
54 { 54 {
55 return mText; 55 return mText;
56 } 56 }
57 57
58 OwnedString BINDINGS_EXPORTED Serialize() const; 58 OwnedString BINDINGS_EXPORTED Serialize() const;
59 59
60 static Filter* BINDINGS_EXPORTED FromText(DependentString& text); 60 static Filter* BINDINGS_EXPORTED FromText(DependentString& text);
61 61
62 template<typename T> 62 template<typename T>
63 T* As(); 63 T* As()
64 {
65 if ((mType & T::classType) != T::classType)
66 return nullptr;
67
68 return static_cast<T*>(this);
69 }
70
71 template<typename T>
72 const T* As() const
73 {
74 if ((mType & T::classType) != T::classType)
75 return nullptr;
76
77 return static_cast<const T*>(this);
78 }
64 }; 79 };
65 80
66 typedef intrusive_ptr<Filter> FilterPtr; 81 typedef intrusive_ptr<Filter> FilterPtr;
LEFTRIGHT

Powered by Google App Engine
This is Rietveld