Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: compiled/filter/InvalidFilter.h

Issue 29574591: Issue 5258 - Implement Filter::As<>() method to make working with filters easier from C++ code (Closed) Base URL: https://hg.adblockplus.org/adblockpluscore
Left Patch Set: Created Oct. 12, 2017, 12:13 p.m.
Right Patch Set: Removed unnecessary base class check Created Oct. 13, 2017, 4:57 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « compiled/filter/Filter.cpp ('k') | compiled/filter/InvalidFilter.cpp » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-present eyeo GmbH 3 * Copyright (C) 2006-present eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 * GNU General Public License for more details. 12 * GNU General Public License for more details.
13 * 13 *
14 * You should have received a copy of the GNU General Public License 14 * You should have received a copy of the GNU General Public License
15 * along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>. 15 * along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>.
16 */ 16 */
17 17
18 #pragma once 18 #pragma once
19 19
20 #include "Filter.h" 20 #include "Filter.h"
21 #include "../bindings/runtime.h" 21 #include "../bindings/runtime.h"
22 22
23 class InvalidFilter : public Filter 23 class InvalidFilter : public Filter
24 { 24 {
25 public: 25 public:
26 static constexpr Type classType = Type::INVALID;
26 explicit InvalidFilter(const String& text, const String& reason); 27 explicit InvalidFilter(const String& text, const String& reason);
27 const String& BINDINGS_EXPORTED GetReason() const 28 const String& BINDINGS_EXPORTED GetReason() const
28 { 29 {
29 return mReason; 30 return mReason;
30 }; 31 };
31 private: 32 private:
32 OwnedString mReason; 33 OwnedString mReason;
33 }; 34 };
34
35 template<>
36 inline InvalidFilter* Filter::As<InvalidFilter>()
37 {
38 if ((mType & Type::INVALID) == Type::INVALID)
39 return nullptr;
40
41 return static_cast<InvalidFilter*>(this);
42 }
LEFTRIGHT

Powered by Google App Engine
This is Rietveld