Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: compiled/filter/RegExpFilter.h

Issue 29574591: Issue 5258 - Implement Filter::As<>() method to make working with filters easier from C++ code (Closed) Base URL: https://hg.adblockplus.org/adblockpluscore
Left Patch Set: Created Oct. 12, 2017, 12:13 p.m.
Right Patch Set: Removed unnecessary base class check Created Oct. 13, 2017, 4:57 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « compiled/filter/InvalidFilter.cpp ('k') | compiled/filter/WhitelistFilter.h » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-present eyeo GmbH 3 * Copyright (C) 2006-present eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 85 matching lines...) Expand 10 before | Expand all | Expand 10 after
96 { 96 {
97 private: 97 private:
98 void ParseSitekeys(const String& sitekeys) const; 98 void ParseSitekeys(const String& sitekeys) const;
99 99
100 protected: 100 protected:
101 RegExpFilterData mData; 101 RegExpFilterData mData;
102 102
103 DomainMap* GetDomains() const override; 103 DomainMap* GetDomains() const override;
104 SitekeySet* GetSitekeys() const override; 104 SitekeySet* GetSitekeys() const override;
105 public: 105 public:
106 static constexpr Type classType = Type::REGEXP;
106 explicit RegExpFilter(Type type, const String& text, const RegExpFilterData& d ata); 107 explicit RegExpFilter(Type type, const String& text, const RegExpFilterData& d ata);
107 ~RegExpFilter(); 108 ~RegExpFilter();
108 static Type Parse(DependentString& text, DependentString& error, 109 static Type Parse(DependentString& text, DependentString& error,
109 RegExpFilterData& data); 110 RegExpFilterData& data);
110 static void GenerateCustomBindings(); 111 static void GenerateCustomBindings();
111 bool BINDINGS_EXPORTED Matches(const String& location, int typeMask, 112 bool BINDINGS_EXPORTED Matches(const String& location, int typeMask,
112 DependentString& docDomain, bool thirdParty, const String& sitekey) const; 113 DependentString& docDomain, bool thirdParty, const String& sitekey) const;
113 }; 114 };
114
115 template<>
116 inline RegExpFilter* Filter::As<RegExpFilter>()
117 {
118 if ((mType & Type::REGEXP) == Type::REGEXP)
119 return nullptr;
120
121 return static_cast<RegExpFilter*>(this);
122 }
LEFTRIGHT

Powered by Google App Engine
This is Rietveld