Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: compiled/subscription/UserDefinedSubscription.cpp

Issue 29574591: Issue 5258 - Implement Filter::As<>() method to make working with filters easier from C++ code (Closed) Base URL: https://hg.adblockplus.org/adblockpluscore
Left Patch Set: Created Oct. 12, 2017, 12:13 p.m.
Right Patch Set: Removed unnecessary base class check Created Oct. 13, 2017, 4:57 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « compiled/subscription/UserDefinedSubscription.h ('k') | no next file » | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-present eyeo GmbH 3 * Copyright (C) 2006-present eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 26 matching lines...) Expand all
37 if (type == Filter::Type::WHITELIST) 37 if (type == Filter::Type::WHITELIST)
38 return FilterCategory::WHITELIST; 38 return FilterCategory::WHITELIST;
39 if ((type & Filter::Type::ELEMHIDEBASE) == Filter::Type::ELEMHIDEBASE) 39 if ((type & Filter::Type::ELEMHIDEBASE) == Filter::Type::ELEMHIDEBASE)
40 return FilterCategory::ELEMHIDE; 40 return FilterCategory::ELEMHIDE;
41 41
42 return FilterCategory::NONE; 42 return FilterCategory::NONE;
43 } 43 }
44 } 44 }
45 45
46 UserDefinedSubscription::UserDefinedSubscription(const String& id) 46 UserDefinedSubscription::UserDefinedSubscription(const String& id)
47 : Subscription(Type::USERDEFINED, id), mDefaults(0) 47 : Subscription(classType, id), mDefaults(0)
48 { 48 {
49 } 49 }
50 50
51 bool UserDefinedSubscription::IsDefaultFor(const Filter& filter) const 51 bool UserDefinedSubscription::IsDefaultFor(const Filter& filter) const
52 { 52 {
53 return mDefaults & filterTypeToCategory(filter.mType); 53 return mDefaults & filterTypeToCategory(filter.mType);
54 } 54 }
55 55
56 void UserDefinedSubscription::MakeDefaultFor(const Filter& filter) 56 void UserDefinedSubscription::MakeDefaultFor(const Filter& filter)
57 { 57 {
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
95 if (mDefaults & FilterCategory::BLOCKING) 95 if (mDefaults & FilterCategory::BLOCKING)
96 result.append(u" blocking"_str); 96 result.append(u" blocking"_str);
97 if (mDefaults & FilterCategory::WHITELIST) 97 if (mDefaults & FilterCategory::WHITELIST)
98 result.append(u" whitelist"_str); 98 result.append(u" whitelist"_str);
99 if (mDefaults & FilterCategory::ELEMHIDE) 99 if (mDefaults & FilterCategory::ELEMHIDE)
100 result.append(u" elemhide"_str); 100 result.append(u" elemhide"_str);
101 result.append(u'\n'); 101 result.append(u'\n');
102 } 102 }
103 return result; 103 return result;
104 } 104 }
LEFTRIGHT

Powered by Google App Engine
This is Rietveld