compiled/filter/RegExpFilter.h - Issue 29574591: Issue 5258 - Implement Filter::As<>() method to make working with filters easier from C++ code

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: compiled/filter/RegExpFilter.h

Issue 29574591: Issue 5258 - Implement Filter::As<>() method to make working with filters easier from C++ code (Closed) Base URL: https://hg.adblockplus.org/adblockpluscore

Patch Set: Use static classType member Created Oct. 13, 2017, 11:40 a.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: compiled/filter/RegExpFilter.h

===================================================================

--- a/compiled/filter/RegExpFilter.h

+++ b/compiled/filter/RegExpFilter.h

@@ -98,16 +98,17 @@ private:

void ParseSitekeys(const String& sitekeys) const;

protected:

RegExpFilterData mData;

DomainMap* GetDomains() const override;

SitekeySet* GetSitekeys() const override;

public:

+ static constexpr Type classType = Type::REGEXP;

explicit RegExpFilter(Type type, const String& text, const RegExpFilterData& data);

~RegExpFilter();

static Type Parse(DependentString& text, DependentString& error,

RegExpFilterData& data);

static void GenerateCustomBindings();

bool BINDINGS_EXPORTED Matches(const String& location, int typeMask,

DependentString& docDomain, bool thirdParty, const String& sitekey) const;

};

« no previous file with comments | « compiled/filter/InvalidFilter.cpp ('k') | compiled/filter/WhitelistFilter.h » ('j') | compiled/subscription/Subscription.h » ('J')