compiled/filter/ActiveFilter.h - Issue 29574591: Issue 5258 - Implement Filter::As<>() method to make working with filters easier from C++ code

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: compiled/filter/ActiveFilter.h

Issue 29574591: Issue 5258 - Implement Filter::As<>() method to make working with filters easier from C++ code (Closed) Base URL: https://hg.adblockplus.org/adblockpluscore

Patch Set: Removed unnecessary base class check Created Oct. 13, 2017, 4:57 p.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: compiled/filter/ActiveFilter.h

===================================================================

--- a/compiled/filter/ActiveFilter.h

+++ b/compiled/filter/ActiveFilter.h

@@ -51,16 +51,17 @@ protected:

void AddSitekey(const String& sitekey) const;

virtual DomainMap* GetDomains() const;

virtual SitekeySet* GetSitekeys() const;

mutable std::unique_ptr<DomainMap> mDomains;

mutable std::unique_ptr<SitekeySet> mSitekeys;

private:

bool mIgnoreTrailingDot;

public:

+ static constexpr Type classType = Type::ACTIVE;

explicit ActiveFilter(Type type, const String& text, bool ignoreTrailingDot);

FILTER_PROPERTY(bool, mDisabled, FILTER_DISABLED, GetDisabled, SetDisabled);

FILTER_PROPERTY(unsigned int, mHitCount, FILTER_HITCOUNT,

GetHitCount, SetHitCount);

FILTER_PROPERTY(unsigned int, mLastHit, FILTER_LASTHIT,

GetLastHit, SetLastHit);

bool BINDINGS_EXPORTED IsActiveOnDomain(DependentString& docDomain,

const String& sitekey) const;

« no previous file with comments | « no previous file | compiled/filter/BlockingFilter.h » ('j') | no next file with comments »