Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(785)

Issue 29574648: Issue 5860 - options page is broken in test enviroment (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 months ago by saroyanm
Modified:
2 months ago
Visibility:
Public.

Description

Issue 5860 - options page is broken in test enviroment

Patch Set 1 #

Total comments: 6

Patch Set 2 : Addressed Sebastian's comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M ext/common.js View 1 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 5
saroyanm
Thomas can you please have a look.
2 months ago (2017-10-12 16:00:28 UTC) #1
saroyanm
This affects only test environment, so it's not urgent.
2 months ago (2017-10-12 16:01:47 UTC) #2
Sebastian Noack
https://codereview.adblockplus.org/29574648/diff/29574649/ext/common.js File ext/common.js (right): https://codereview.adblockplus.org/29574648/diff/29574649/ext/common.js#newcode90 ext/common.js:90: let parts = selectedLocale.split("_"); This seems wrong. window.navigator.language still ...
2 months ago (2017-10-12 18:10:33 UTC) #3
saroyanm
Thanks Sebastian for having a look. https://codereview.adblockplus.org/29574648/diff/29574649/ext/common.js File ext/common.js (right): https://codereview.adblockplus.org/29574648/diff/29574649/ext/common.js#newcode90 ext/common.js:90: let parts = ...
2 months ago (2017-10-12 20:26:38 UTC) #4
Sebastian Noack
2 months ago (2017-10-12 21:54:11 UTC) #5
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5