Issue 5159 - Expose collapse property for BlockingFilter

test/filterClasses.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 39 matching lines @@
 {
   // fields are:
   // text, type, typeName, collapse (optional, BlockingFilter only)
   let tests = [
     ["!asdf", CommentFilter, "comment"],
     ["asdf", BlockingFilter, "blocking", 1],
     ["asdf$image,~collapse", BlockingFilter, "blocking", 0],
     ["/asdf/", BlockingFilter, "blocking", 1],
     ["/asdf??+/", InvalidFilter, "invalid"],
     ["@@asdf", WhitelistFilter, "whitelist"],
-    ["@@asdf$image,~collapse", WhitelistFilter, "whitelist", 0],
+    ["@@asdf$image,~collapse", WhitelistFilter, "whitelist"],
     ["@@/asdf/", WhitelistFilter, "whitelist"],
     ["@@/asdf??+/", InvalidFilter, "invalid"],
     ["##asdf", ElemHideFilter, "elemhide"],
     ["#@#asdf", ElemHideException, "elemhideexception"],
     ["foobar##asdf", ElemHideFilter, "elemhide"],
     ["foobar#@#asdf", ElemHideException, "elemhideexception"],
     ["foobar##a", ElemHideFilter, "elemhide"],
     ["foobar#@#a", ElemHideException, "elemhideexception"],
 
     ["foobar#asdf", BlockingFilter, "blocking", 1],
     ["foobar|foobas##asdf", BlockingFilter, "blocking", 1],
-    ["foobar##asdf{asdf}", BlockingFilter, "blocking", 1],
+    ["foobar##asdf{asdf}", ElemHideFilter, "elemhide"],
     ["foobar##", BlockingFilter, "blocking", 1],
     ["foobar#@#", BlockingFilter, "blocking", 1],
     ["asdf$foobar", InvalidFilter, "invalid"],
     ["asdf$image,foobar", InvalidFilter, "invalid"],
     ["asdf$image=foobar", BlockingFilter, "blocking", 1],
     ["asdf$image=foobar=xyz,~collapse", BlockingFilter, "blocking", 0],
 
     ["##foo[-abp-properties='something']bar", InvalidFilter, "invalid"],
     ["#@#foo[-abp-properties='something']bar", ElemHideException, "elemhideexception"],
     ["example.com##foo[-abp-properties='something']bar", ElemHideEmulationFilter, "elemhideemulation"],
@@ skipping 13 matching lines @@
     ["example.com##[-abp-properties=(something)]", ElemHideEmulationFilter, "elemhideemulation"],
     ["example.com#@#[-abp-properties=(something)]", ElemHideException, "elemhideexception"]
   ];
   for (let [text, type, typeName, collapse] of tests)
   {
     let filter = Filter.fromText(text);
     test.ok(filter instanceof Filter, "Got filter for " + text);
     test.equal(filter.text, text, "Correct filter text for " + text);
     test.ok(filter instanceof type, "Correct filter type for " + text);
     test.equal(filter.type, typeName, "Type name for " + text + " is " + typeName);
     if (filter instanceof BlockingFilter)

[sergei, 2017/11/21 16:17:01]

What about checking that `filter.collapse` and `collapse` are undefined if the
filter is not a blocking filter? (I've just seen ["@@asdf$image,~collapse",
WhitelistFilter, "whitelist", 0],).

[hub, 2017/11/21 17:42:47]

done.

       test.equal(filter.collapse, collapse);
+    else
+      test.equal(filter.collapse, undefined);
     if (type == InvalidFilter)
       test.ok(filter.reason, "Invalid filter " + text + " has a reason set");
     filter.delete();
   }
   test.done();
 };
 
 exports.testClassHierarchy = function(test)
 {
   let allClasses = [
@@ skipping 260 matching lines @@
 
   for (let [text, selector, selectorDomain] of tests)
   {
     doTest(text, selector, selectorDomain);
     doTest(text.replace("##", "#@#"), selector, selectorDomain);
   }
 
   test.done();
 };
 
+exports.testElemHideRulesWithBraces = function(test)
+{
+  let filter = Filter.fromText("###foo{color: red}");
+  test.equal(filter.type, "elemhide");
+  test.equal(filter.selector, "#foo\\7B color: red\\7D ");
+  filter.delete();
+
+  filter = Filter.fromText("foo.com##[-abp-properties='/margin: [3-4]{2}/']");
+  test.equal(filter.type, "elemhideemulation");
+  test.equal(filter.selector, "[-abp-properties='/margin: [3-4]\\7B 2\\7D /']");
+  filter.delete();
+
+  test.done();
+};
+
 exports.testNotifications = function(test)
 {
   function checkNotifications(action, expected, message)
   {
     let result = null;
     let listener = (topic, filter) =>
     {
       if (result)
         test.ok(false, "Got more that one notification - " + message);
       else
@@ skipping 37 matching lines @@
     filter.hitCount++;
   }, ["filter.hitCount", "foobar"], "Increasing filter hit counts");
   checkNotifications(() =>
   {
     filter.hitCount = 0;
   }, ["filter.hitCount", "foobar"], "Resetting filter hit counts");
 
   filter.delete();
   test.done();
 };