Issue 5691 - Create Breadcrumbs Component for help.eyeo.com

static/scss/components/_breadcrumbs.scss

+// This file is part of help.eyeo.com.
+// Copyright (C) 2017 Eyeo GmbH
+//
+// help.eyeo.com is free software: you can redistribute it and/or modify
+// it under the terms of the GNU General Public License as published by
+// the Free Software Foundation, either version 3 of the License, or
+// (at your option) any later version.
+//
+// help.eyeo.com is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+// GNU General Public License for more details.
+//
+// You should have received a copy of the GNU General Public License
+// along with help.eyeo.com.  If not, see <http://www.gnu.org/licenses/>.
+
+.breadcrumbs
+{
+  padding-top: $md;

[juliandoucette, 2017/10/13 11:39:55]

NIT/Suggest: 1em?

[ire, 2017/10/16 14:17:41]

Done.

+  padding-bottom: $md;
+  border-bottom: 1px solid $gray-light;
+  background-color: $white;
+}
+
+.breadcrumbs li
+{
+  display: inline-block;

[juliandoucette, 2017/10/13 11:39:54]

NIT: This will cause a whitespace between list items that will scale with the
font-size. I would use the floating box model instead.

[ire, 2017/10/16 14:17:41]

Done.

+  position: relative;
+  padding-right: $lg;
+  color: $gray-dark;

[juliandoucette, 2017/10/13 11:39:55]

NIT: Isn't the blue link supposed to be grey too?

[ire, 2017/10/16 14:17:41]

What blue link?

[juliandoucette, 2017/10/17 11:15:26]

The first breadcrumb is blue and the second is dark grey.

(I probably could have placed this comment somewhere else)

[ire, 2017/10/23 15:53:09]

Done.

[ire, 2017/10/23 15:53:09]

Oh it does't show that way for me. I'll move this to styling the link instead of
the li

+  font-size: $small-font;
+  font-weight: $bold-weight;

[juliandoucette, 2017/10/13 11:39:54]

This is semibold in the mockups & styleguide

[ire, 2017/10/16 14:17:41]

We don't have a semi-bold weight for the font, and I didn't think it was
necessary to load a another weight only for this purpose. Do you think we
should?

[juliandoucette, 2017/10/17 11:15:26]

I think that all weights are supposed to be semi-bold according to the
styleguide?

(And I think this will look better if semi-bold is distinguishable from
regular.)

[ire, 2017/10/23 15:53:09]

As we discussed will handle in this issue
https://issues.adblockplus.org/ticket/5903

+  text-transform: uppercase;
+}
+
+[dir="rtl"] .breadcrumbs li
+{
+  padding-right: 0;

[juliandoucette, 2017/10/13 11:39:55]

SuperNIT: shorthand padding causes less characters (we should decide which way
to go in our coding style if we haven't already - not that it matters very much)

PS: "SuperNIT" (which I made up?) means less than a NIT not more than a NIT

[ire, 2017/10/16 14:17:41]

I agree we should add it to our coding style.

In this case, I prefer this way because it's clearer that I'm overriding the
padding-right that's there by default. Since in the ltr state, I'm only applying
padding to one side, I want that to be the same here. Instead of doing
padding-right on ltr, then specifying padding on all sides for rtl. 
Ack.

+  padding-left: $lg;

[juliandoucette, 2017/10/13 11:39:54]

NIT/Suggest: 2em?

[ire, 2017/10/16 14:17:41]

Done.

+}
+
+.breadcrumbs li:after
+{
+  position: absolute;
+  top: 0.25em;

[juliandoucette, 2017/10/13 11:39:55]

NIT: This looks slightly too low
Suggest: explain this value via comment

[ire, 2017/10/16 14:17:42]

Done.

+  right: $lg / 4;

[juliandoucette, 2017/10/13 11:39:55]

NIT/Suggest: Explain this via comment.

[ire, 2017/10/16 14:17:41]

Done.

+  width: 1em;
+  height: 1em;
+  background-image: url(/img/png/arrow-icon-right-gray.png);

[juliandoucette, 2017/10/13 11:39:54]

NIT: Isn't this supposed to be lighter?

[ire, 2017/10/16 14:17:41]

Done.

+  background-repeat: no-repeat;
+  background-position: center;
+  background-size: 0.6em 0.9em;
+  content: "";
+}
+
+[dir="rtl"] .breadcrumbs li:after
+{
+  right: auto;
+  left: $lg / 4;
+  background-image: url(/img/png/arrow-icon-left-gray.png);
+}
+
+.breadcrumbs li:last-child:after
+{
+  content: none;
+}