Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: templates/article.tmpl

Issue 29575597: Issue 5691 - Create Breadcrumbs Component for help.eyeo.com (Closed) Base URL: https://hg.adblockplus.org/help.eyeo.com
Patch Set: Update link color Created Oct. 23, 2017, 3:52 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
OLDNEW
1 {% extends "templates/default" %} 1 {% extends "templates/default" %}
2 2
3 {% set product = products[product_id] %} 3 {% set product = products[product_id] %}
4 4
5 {% block body %} 5 {% block body %}
6 [Breadcrumbs] 6 <nav aria-label="{{ "Breadcrumb" | translate("breadcrumb-label", "Label") }}" cl ass="breadcrumb">
juliandoucette 2017/10/24 09:51:13 NIT: "Breadcrumb" is singular but you are referrin
ire 2017/10/25 10:00:06 Yes I actually had it as "Breadcrumbs" before, but
juliandoucette 2017/10/25 12:15:03 Acknowledged.
7 <ol class="container clearfix" itemscope itemtype="http://schema.org/Breadcrum bList">
8 <li itemprop="itemListElement" itemscope itemtype="http://schema.org/ListIte m">
9 <a itemscope itemtype="http://schema.org/Thing" itemprop="item" href="{{ p roduct.slug }}">
juliandoucette 2017/10/24 09:51:14 Suggest: http://schema.org/Product
ire 2017/10/25 10:00:06 The ABP Help Center Home isn't really a product. I
juliandoucette 2017/10/25 12:15:03 Acknowledged.
10 <img class="heading-icon" src="/img/png/logo-{{ product_id }}.png" srcse t="/img/svg/logo-{{ product_id }}.svg 2x" alt="{{ product.full_name+" Logo" | tr anslate(product_id+"-logo-alt", "Image alt text") }}">
juliandoucette 2017/10/24 09:51:14 NIT: I don't know why extra spaces with text-decor
ire 2017/10/25 10:00:06 I'll address this in this issue with the alignment
juliandoucette 2017/10/25 12:15:03 Acknowledged.
11 <span itemprop="name">{{ product.full_name | translate(product_id+"-name ", "Product name") }}</span>
12 </a>
13 <meta itemprop="position" content="1" />
14 </li>
15 <li itemprop="itemListElement" itemscope itemtype="http://schema.org/ListIte m">
16 <a itemscope itemtype="http://schema.org/Thing" itemprop="item" href="{{ p age }}" aria-current="page">
17 <span itemprop="name">{{ title | translate(get_page_name(page) + "-title ", "Article title") }}</span>
18 </a>
19 <meta itemprop="position" content="2" />
20 </li>
21 </ol>
22 </nav>
7 23
8 <main id="main" class="container clearfix"> 24 <main id="main" class="container clearfix">
9 <article class="article card {{ product_id }}-card section column two-thirds"> 25 <article class="article card {{ product_id }}-card section column two-thirds">
10 <h1 class="article-heading"> 26 <h1 class="article-heading">
11 <img class="heading-icon" src="/img/png/logo-{{ product_id }}.png" srcse t="/img/svg/logo-{{ product_id }}.svg 2x" alt="{{ product.full_name+" Logo" | tr anslate( product_id+"-logo-alt", "Image alt text") }}"> 27 <img class="heading-icon" src="/img/png/logo-{{ product_id }}.png" srcse t="/img/svg/logo-{{ product_id }}.svg 2x" alt="{{ product.full_name+" Logo" | tr anslate( product_id+"-logo-alt", "Image alt text") }}">
12 28
13 {{ title | translate( get_page_name(page) + "-title", "Article title") } } 29 {{ title | translate( get_page_name(page) + "-title", "Article title") } }
14 </h1> 30 </h1>
15 31
16 {% if hide_browser_selector is not defined %} 32 {% if hide_browser_selector is not defined %}
17 <div class="article-browser-selector"> 33 <div class="article-browser-selector">
18 [Browser selector] 34 [Browser selector]
19 </div> 35 </div>
20 {% endif %} 36 {% endif %}
21 37
22 <div class="article-body content"> 38 <div class="article-body content">
23 {{ body | safe }} 39 {{ body | safe }}
24 </div> 40 </div>
25 </article> 41 </article>
26 <aside class="section column one-third"> 42 <aside class="section column one-third">
27 <? include product-topics-accordion ?> 43 <? include product-topics-accordion ?>
28 </aside> 44 </aside>
29 </main> 45 </main>
30 46
31 <script id="no-content-for-platform-message" type="text/template"> 47 <script id="no-content-for-platform-message" type="text/template">
32 <p>{{ "Unfortunately, there is no content specific for your current browser. P lease use the dropdown menu above to choose a different browser." | translate("n o-content-for-platform-message", "paragraph") }}</p> 48 <p>{{ "Unfortunately, there is no content specific for your current browser. P lease use the dropdown menu above to choose a different browser." | translate("n o-content-for-platform-message", "paragraph") }}</p>
33 </script> 49 </script>
34 {% endblock %} 50 {% endblock %}
OLDNEW
« static/scss/components/_breadcrumb.scss ('K') | « static/scss/main.scss ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld