Delta Between Two Patch Sets: templates/article.tmpl
Issue 29575597:
Issue 5691 - Create Breadcrumbs Component for help.eyeo.com (Closed)
Base URL: https://hg.adblockplus.org/help.eyeo.com
Left Patch Set:
Created Oct. 13, 2017, 10:27 a.m.
Right Patch Set: Addressed NITs
Created Oct. 25, 2017, 9:59 a.m.
| Left: | ||
| Right: |
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with change/comment
|
« static/scss/main.scss ('k')
|
no next file »
|
no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| LEFT | RIGHT |
|---|---|
| 1 {% extends "templates/default" %} | 1 {% extends "templates/minimal" %} |
| 2 | 2 |
| 3 {% set product = products[product_id] %} | 3 {% set product = products[product_id] %} |
| 4 | 4 |
| 5 {% block body %} | 5 {% block body %} |
| 6 <nav class="breadcrumbs"> | 6 <nav aria-label="{{ "Breadcrumb" | translate("breadcrumb-label", "Label") }}" cl ass="breadcrumb"> |
|
juliandoucette
2017/10/13 11:39:55
NIT/Suggest: Add aria-label
Source: https://www.
ire
2017/10/16 14:17:42
Done.
| |
| 7 <ol class="container" itemscope itemtype="http://schema.org/BreadcrumbList"> | 7 <ol class="container clearfix" itemscope itemtype="http://schema.org/Breadcrum bList"> |
|
juliandoucette
2017/10/13 11:39:55
NIT: I'm guessing that you copied this from an exa
ire
2017/10/16 14:17:42
It was from the link you shared in issue #5440 act
| |
| 8 <li itemprop="itemListElement" itemscope itemtype="http://schema.org/ListIte m"> | 8 <li itemprop="itemListElement" itemscope itemtype="http://schema.org/ListIte m"> |
| 9 <a itemscope itemtype="http://schema.org/Thing" itemprop="item" href="{{ p roduct.slug }}"> | 9 <a itemscope itemtype="http://schema.org/Thing" itemprop="item" href="{{ p roduct.slug }}"> |
| 10 <img class="heading-icon" src="/img/png/logo-{{ product_id }}.png" srcse t="/img/svg/logo-{{ product_id }}.svg 2x" alt="{{ product.full_name+" Logo" | tr anslate(product_id+"-logo-alt", "Image alt text") }}"> | 10 <img class="heading-icon" src="/img/png/logo-{{ product_id }}.png" srcse t="/img/svg/logo-{{ product_id }}.svg 2x" alt="{{ product.full_name+" Logo" | tr anslate(product_id+"-logo-alt", "Image alt text") }}"> |
|
juliandoucette
2017/10/13 11:39:55
Isn't this logo supposed to be larger?
ire
2017/10/16 14:17:42
Done.
| |
| 11 <span itemprop="name">{{ product.full_name | translate(product_id+"-name ", "Product name") }}</span> | 11 <span itemprop="name">{{ product.full_name | translate(product_id+"-name ", "Product name") }}</span> |
| 12 </a> | 12 </a> |
| 13 <meta itemprop="position" content="1" /> | 13 <meta itemprop="position" content="1" /> |
| 14 </li> | 14 </li> |
| 15 <li itemprop="itemListElement" itemscope itemtype="http://schema.org/ListIte m"> | 15 <li itemprop="itemListElement" itemscope itemtype="http://schema.org/ListIte m"> |
|
juliandoucette
2017/10/13 11:39:55
NIT/Suggest: add aria-current
Source: https://www
ire
2017/10/16 14:17:42
Done.
| |
| 16 <a itemscope itemtype="http://schema.org/Thing" itemprop="item" href="{{ p age }}"> | 16 <a itemscope itemtype="http://schema.org/Thing" itemprop="item" href="{{ p age }}" aria-current="page"> |
| 17 <span itemprop="name">{{ title | translate(get_page_name(page) + "-title ", "Article title") }}</span> | 17 <span itemprop="name">{{ title | translate(get_page_name(page) + "-title ", "Article title") }}</span> |
| 18 </a> | 18 </a> |
| 19 <meta itemprop="position" content="2" /> | 19 <meta itemprop="position" content="2" /> |
| 20 </li> | 20 </li> |
| 21 </ol> | 21 </ol> |
| 22 </nav> | 22 </nav> |
| 23 | 23 |
| 24 <main id="main" class="container clearfix"> | 24 <main id="main" class="container clearfix"> |
| 25 <article class="article card {{ product_id }}-card section column two-thirds"> | 25 <article class="article card {{ product_id }}-card section column two-thirds"> |
| 26 <h1 class="article-heading"> | 26 <h1 class="article-heading"> |
| 27 <img class="heading-icon" src="/img/png/logo-{{ product_id }}.png" srcse t="/img/svg/logo-{{ product_id }}.svg 2x" alt="{{ product.full_name+" Logo" | tr anslate( product_id+"-logo-alt", "Image alt text") }}"> | 27 <img class="heading-icon" src="/img/png/logo-{{ product_id }}.png" srcse t="/img/svg/logo-{{ product_id }}.svg 2x" alt="{{ product.full_name+" Logo" | tr anslate( product_id+"-logo-alt", "Image alt text") }}"> |
| 28 | 28 |
| 29 {{ title | translate( get_page_name(page) + "-title", "Article title") } } | 29 {{ title | translate( get_page_name(page) + "-title", "Article title") } } |
| 30 </h1> | 30 </h1> |
| 31 | 31 |
| 32 {% if hide_browser_selector is not defined %} | 32 {% if hide_browser_selector is not defined %} |
| 33 <div class="article-browser-selector"> | 33 <div class="article-browser-selector"> |
| 34 [Browser selector] | 34 [Browser selector] |
| 35 </div> | 35 </div> |
| 36 {% endif %} | 36 {% endif %} |
| 37 | 37 |
| 38 <div class="article-body content"> | 38 <div class="article-body content"> |
| 39 {{ body | safe }} | 39 {{ body | safe }} |
| 40 </div> | 40 </div> |
| 41 </article> | 41 </article> |
| 42 <aside class="section column one-third"> | 42 <aside class="section column one-third"> |
| 43 <? include product-topics-accordion ?> | 43 <? include product-topics-accordion ?> |
| 44 </aside> | 44 </aside> |
| 45 </main> | 45 </main> |
| 46 {% endblock %} | 46 |
| 47 <script id="no-content-for-platform-message" type="text/template"> | |
| 48 <p>{{ "Unfortunately, there is no content specific for your current browser. P lease use the dropdown menu above to choose a different browser." | translate("n o-content-for-platform-message", "paragraph") }}</p> | |
| 49 </script> | |
| 50 {% endblock %} | |
| 51 | |
| 52 {% block footer %} | |
| 53 <? include contact ?> | |
| 54 {% endblock %} | |
| LEFT | RIGHT |
« static/scss/main.scss ('k')
|
no next file »
|
Toggle Intra-line Diffs ('i')
|
Expand Comments ('e')
|
Collapse Comments ('c')
|
Toggle Comments ('s')
