Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: static/scss/components/_breadcrumb.scss

Issue 29575597: Issue 5691 - Create Breadcrumbs Component for help.eyeo.com (Closed) Base URL: https://hg.adblockplus.org/help.eyeo.com
Left Patch Set: Update link color Created Oct. 23, 2017, 3:52 p.m.
Right Patch Set: Addressed NITs Created Oct. 25, 2017, 9:59 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « static/img/png/arrow-icon-right-gray.png ('k') | static/scss/main.scss » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 // This file is part of help.eyeo.com. 1 // This file is part of help.eyeo.com.
2 // Copyright (C) 2017 Eyeo GmbH 2 // Copyright (C) 2017 Eyeo GmbH
3 // 3 //
4 // help.eyeo.com is free software: you can redistribute it and/or modify 4 // help.eyeo.com is free software: you can redistribute it and/or modify
5 // it under the terms of the GNU General Public License as published by 5 // it under the terms of the GNU General Public License as published by
6 // the Free Software Foundation, either version 3 of the License, or 6 // the Free Software Foundation, either version 3 of the License, or
7 // (at your option) any later version. 7 // (at your option) any later version.
8 // 8 //
9 // help.eyeo.com is distributed in the hope that it will be useful, 9 // help.eyeo.com is distributed in the hope that it will be useful,
10 // but WITHOUT ANY WARRANTY; without even the implied warranty of 10 // but WITHOUT ANY WARRANTY; without even the implied warranty of
11 // MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 11 // MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 // GNU General Public License for more details. 12 // GNU General Public License for more details.
13 // 13 //
14 // You should have received a copy of the GNU General Public License 14 // You should have received a copy of the GNU General Public License
15 // along with help.eyeo.com. If not, see <http://www.gnu.org/licenses/>. 15 // along with help.eyeo.com. If not, see <http://www.gnu.org/licenses/>.
16 16
17 .breadcrumb 17 .breadcrumb
18 { 18 {
19 padding-top: 1em; 19 padding-top: 0.75em;
20 padding-bottom: 1em; 20 padding-bottom: 0.75em;
21 border-bottom: 1px solid $gray-light; 21 border-bottom: 1px solid $gray-light;
22 background-color: $white; 22 background-color: $white;
23 } 23 }
24 24
25 .breadcrumb li 25 .breadcrumb li
juliandoucette 2017/10/24 09:51:13 I think that this text is too close together, vert
ire 2017/10/25 10:00:06 Done.
26 { 26 {
27 float: left; 27 float: left;
28 position: relative; 28 position: relative;
29 padding-right: 2em; 29 padding: 0.25em 2em 0.25em 0;
30 font-size: $small-font; 30 font-size: $small-font;
31 font-weight: $bold-weight; 31 font-weight: $bold-weight;
32 text-transform: uppercase; 32 text-transform: uppercase;
33 } 33 }
34 34
35 [dir="rtl"] .breadcrumb li 35 [dir="rtl"] .breadcrumb li
36 { 36 {
37 float: right; 37 float: right;
38 padding-right: 0; 38 padding: 0.25em 0 0.25em 2em;
39 padding-left: 2em;
40 } 39 }
41 40
42 .breadcrumb li:after 41 .breadcrumb li:after
43 { 42 {
44 position: absolute; 43 position: absolute;
45 top: 0.2em; /* Quarter height of li:after (1em / 4) minus 0.05em */ 44 top: 0.45em; /* Half height of li:after (1em / 2) minus 0.05em */
46 right: 0.5em; /* Quarter space between li (2em / 4) */ 45 right: 0.5em; /* Quarter space between li (2em / 4) */
47 width: 1em; 46 width: 1em;
48 height: 1em; 47 height: 1em;
49 background-image: url(/img/png/arrow-icon-right-gray.png); 48 background-image: url(/img/png/arrow-icon-right-gray.png);
50 background-repeat: no-repeat; 49 background-repeat: no-repeat;
51 background-position: center; 50 background-position: center;
52 background-size: 0.6em 0.9em; 51 background-size: 0.6em 0.9em;
53 content: ""; 52 content: "";
54 } 53 }
55 54
(...skipping 11 matching lines...) Expand all
67 66
68 .breadcrumb li a 67 .breadcrumb li a
69 { 68 {
70 color: $gray-dark; 69 color: $gray-dark;
71 } 70 }
72 71
73 .breadcrumb .heading-icon 72 .breadcrumb .heading-icon
74 { 73 {
75 height: 1.2em; 74 height: 1.2em;
76 } 75 }
LEFTRIGHT

Powered by Google App Engine
This is Rietveld