Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: templates/article.tmpl

Issue 29575597: Issue 5691 - Create Breadcrumbs Component for help.eyeo.com (Closed) Base URL: https://hg.adblockplus.org/help.eyeo.com
Left Patch Set: Update link color Created Oct. 23, 2017, 3:52 p.m.
Right Patch Set: Addressed NITs Created Oct. 25, 2017, 9:59 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « static/scss/main.scss ('k') | no next file » | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 {% extends "templates/default" %} 1 {% extends "templates/minimal" %}
2 2
3 {% set product = products[product_id] %} 3 {% set product = products[product_id] %}
4 4
5 {% block body %} 5 {% block body %}
6 <nav aria-label="{{ "Breadcrumb" | translate("breadcrumb-label", "Label") }}" cl ass="breadcrumb"> 6 <nav aria-label="{{ "Breadcrumb" | translate("breadcrumb-label", "Label") }}" cl ass="breadcrumb">
juliandoucette 2017/10/24 09:51:13 NIT: "Breadcrumb" is singular but you are referrin
ire 2017/10/25 10:00:06 Yes I actually had it as "Breadcrumbs" before, but
juliandoucette 2017/10/25 12:15:03 Acknowledged.
7 <ol class="container clearfix" itemscope itemtype="http://schema.org/Breadcrum bList"> 7 <ol class="container clearfix" itemscope itemtype="http://schema.org/Breadcrum bList">
8 <li itemprop="itemListElement" itemscope itemtype="http://schema.org/ListIte m"> 8 <li itemprop="itemListElement" itemscope itemtype="http://schema.org/ListIte m">
9 <a itemscope itemtype="http://schema.org/Thing" itemprop="item" href="{{ p roduct.slug }}"> 9 <a itemscope itemtype="http://schema.org/Thing" itemprop="item" href="{{ p roduct.slug }}">
juliandoucette 2017/10/24 09:51:14 Suggest: http://schema.org/Product
ire 2017/10/25 10:00:06 The ABP Help Center Home isn't really a product. I
juliandoucette 2017/10/25 12:15:03 Acknowledged.
10 <img class="heading-icon" src="/img/png/logo-{{ product_id }}.png" srcse t="/img/svg/logo-{{ product_id }}.svg 2x" alt="{{ product.full_name+" Logo" | tr anslate(product_id+"-logo-alt", "Image alt text") }}"> 10 <img class="heading-icon" src="/img/png/logo-{{ product_id }}.png" srcse t="/img/svg/logo-{{ product_id }}.svg 2x" alt="{{ product.full_name+" Logo" | tr anslate(product_id+"-logo-alt", "Image alt text") }}">
juliandoucette 2017/10/24 09:51:14 NIT: I don't know why extra spaces with text-decor
ire 2017/10/25 10:00:06 I'll address this in this issue with the alignment
juliandoucette 2017/10/25 12:15:03 Acknowledged.
11 <span itemprop="name">{{ product.full_name | translate(product_id+"-name ", "Product name") }}</span> 11 <span itemprop="name">{{ product.full_name | translate(product_id+"-name ", "Product name") }}</span>
12 </a> 12 </a>
13 <meta itemprop="position" content="1" /> 13 <meta itemprop="position" content="1" />
14 </li> 14 </li>
15 <li itemprop="itemListElement" itemscope itemtype="http://schema.org/ListIte m"> 15 <li itemprop="itemListElement" itemscope itemtype="http://schema.org/ListIte m">
16 <a itemscope itemtype="http://schema.org/Thing" itemprop="item" href="{{ p age }}" aria-current="page"> 16 <a itemscope itemtype="http://schema.org/Thing" itemprop="item" href="{{ p age }}" aria-current="page">
17 <span itemprop="name">{{ title | translate(get_page_name(page) + "-title ", "Article title") }}</span> 17 <span itemprop="name">{{ title | translate(get_page_name(page) + "-title ", "Article title") }}</span>
18 </a> 18 </a>
19 <meta itemprop="position" content="2" /> 19 <meta itemprop="position" content="2" />
20 </li> 20 </li>
(...skipping 20 matching lines...) Expand all
41 </article> 41 </article>
42 <aside class="section column one-third"> 42 <aside class="section column one-third">
43 <? include product-topics-accordion ?> 43 <? include product-topics-accordion ?>
44 </aside> 44 </aside>
45 </main> 45 </main>
46 46
47 <script id="no-content-for-platform-message" type="text/template"> 47 <script id="no-content-for-platform-message" type="text/template">
48 <p>{{ "Unfortunately, there is no content specific for your current browser. P lease use the dropdown menu above to choose a different browser." | translate("n o-content-for-platform-message", "paragraph") }}</p> 48 <p>{{ "Unfortunately, there is no content specific for your current browser. P lease use the dropdown menu above to choose a different browser." | translate("n o-content-for-platform-message", "paragraph") }}</p>
49 </script> 49 </script>
50 {% endblock %} 50 {% endblock %}
51
52 {% block footer %}
53 <? include contact ?>
54 {% endblock %}
LEFTRIGHT

Powered by Google App Engine
This is Rietveld