Unified Diff: templates/article.tmpl
Issue 29575597:
Issue 5691 - Create Breadcrumbs Component for help.eyeo.com (Closed)
Base URL: https://hg.adblockplus.org/help.eyeo.com
Patch Set:
Created Oct. 13, 2017, 10:27 a.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« static/scss/components/_breadcrumbs.scss ('K')
|
« static/scss/main.scss ('k')
|
no next file »
|
no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: templates/article.tmpl |
| =================================================================== |
| --- a/templates/article.tmpl |
| +++ b/templates/article.tmpl |
| @@ -1,14 +1,30 @@ |
| {% extends "templates/default" %} |
| {% set product = products[product_id] %} |
| {% block body %} |
| -[Breadcrumbs] |
| +<nav class="breadcrumbs"> |
|
juliandoucette
2017/10/13 11:39:55
NIT/Suggest: Add aria-label
Source: https://www.
ire
2017/10/16 14:17:42
Done.
|
| + <ol class="container" itemscope itemtype="http://schema.org/BreadcrumbList"> |
|
juliandoucette
2017/10/13 11:39:55
NIT: I'm guessing that you copied this from an exa
ire
2017/10/16 14:17:42
It was from the link you shared in issue #5440 act
|
| + <li itemprop="itemListElement" itemscope itemtype="http://schema.org/ListItem"> |
| + <a itemscope itemtype="http://schema.org/Thing" itemprop="item" href="{{ product.slug }}"> |
| + <img class="heading-icon" src="/img/png/logo-{{ product_id }}.png" srcset="/img/svg/logo-{{ product_id }}.svg 2x" alt="{{ product.full_name+" Logo" | translate(product_id+"-logo-alt", "Image alt text") }}"> |
|
juliandoucette
2017/10/13 11:39:55
Isn't this logo supposed to be larger?
ire
2017/10/16 14:17:42
Done.
|
| + <span itemprop="name">{{ product.full_name | translate(product_id+"-name", "Product name") }}</span> |
| + </a> |
| + <meta itemprop="position" content="1" /> |
| + </li> |
| + <li itemprop="itemListElement" itemscope itemtype="http://schema.org/ListItem"> |
|
juliandoucette
2017/10/13 11:39:55
NIT/Suggest: add aria-current
Source: https://www
ire
2017/10/16 14:17:42
Done.
|
| + <a itemscope itemtype="http://schema.org/Thing" itemprop="item" href="{{ page }}"> |
| + <span itemprop="name">{{ title | translate(get_page_name(page) + "-title", "Article title") }}</span> |
| + </a> |
| + <meta itemprop="position" content="2" /> |
| + </li> |
| + </ol> |
| +</nav> |
| <main id="main" class="container clearfix"> |
| <article class="article card {{ product_id }}-card section column two-thirds"> |
| <h1 class="article-heading"> |
| <img class="heading-icon" src="/img/png/logo-{{ product_id }}.png" srcset="/img/svg/logo-{{ product_id }}.svg 2x" alt="{{ product.full_name+" Logo" | translate( product_id+"-logo-alt", "Image alt text") }}"> |
| {{ title | translate( get_page_name(page) + "-title", "Article title") }} |
| </h1> |
« static/scss/components/_breadcrumbs.scss ('K')
|
« static/scss/main.scss ('k')
|
no next file »
|
no next file with comments »
