build.py - Issue 29575633: Issue 4720 - enable devenv target for Edge packager

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: build.py

Issue 29575633: Issue 4720 - enable devenv target for Edge packager (Closed)

Patch Set: Addressing nit Created Oct. 18, 2017, 2:28 p.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: build.py

diff --git a/build.py b/build.py

index 7c6ac6448dfa5ad8f1667234de83251eb6767a70..aa3c2035eea5688fcbbd9468ccafa250757f161c 100644

--- a/build.py

+++ b/build.py

@@ -197,7 +197,10 @@ def runBuild(baseDir, scriptName, opts, args, type):

def createDevEnv(baseDir, scriptName, opts, args, type):

- import buildtools.packagerChrome as packager

+ if type == 'edge':

+ import buildtools.packagerEdge as packager

+ else:

+ import buildtools.packagerChrome as packager

file = StringIO()

packager.createBuild(baseDir, type=type, outFile=file, devenv=True, releaseBuild=True)

@@ -394,7 +397,7 @@ with addCommand(runBuild, 'build') as command:

with addCommand(createDevEnv, 'devenv') as command:

command.shortDescription = 'Set up a development environment'

command.description = 'Will set up or update the devenv folder as an unpacked extension folder for development.'

- command.supportedTypes = {'gecko', 'chrome'}

+ command.supportedTypes = {'gecko', 'chrome', 'edge'}

with addCommand(setupTranslations, 'setuptrans') as command:

command.shortDescription = 'Sets up translation languages'

« no previous file with comments | « no previous file | packagerChrome.py » ('j') | no next file with comments »