Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: desktop-options.html

Issue 29578574: Issue 5632 - Use checkboxes for toggling acceptable ads (Closed)
Patch Set: Addressed Ire's comments Created Oct. 19, 2017, 8:40 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | desktop-options.js » ('j') | desktop-options.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <!DOCTYPE html> 1 <!DOCTYPE html>
2 <!-- 2 <!--
3 - This file is part of Adblock Plus <https://adblockplus.org/>, 3 - This file is part of Adblock Plus <https://adblockplus.org/>,
4 - Copyright (C) 2006-present eyeo GmbH 4 - Copyright (C) 2006-present eyeo GmbH
5 - 5 -
6 - Adblock Plus is free software: you can redistribute it and/or modify 6 - Adblock Plus is free software: you can redistribute it and/or modify
7 - it under the terms of the GNU General Public License version 3 as 7 - it under the terms of the GNU General Public License version 3 as
8 - published by the Free Software Foundation. 8 - published by the Free Software Foundation.
9 - 9 -
10 - Adblock Plus is distributed in the hope that it will be useful, 10 - Adblock Plus is distributed in the hope that it will be useful,
(...skipping 79 matching lines...) Expand 10 before | Expand all | Expand 10 after
90 <span data-tooltip="options_protection_%value%_tooltip"></span> 90 <span data-tooltip="options_protection_%value%_tooltip"></span>
91 </template> 91 </template>
92 </ul> 92 </ul>
93 </section> 93 </section>
94 <section class="cols"> 94 <section class="cols">
95 <header> 95 <header>
96 <h2 class="i18n_options_acceptableAds_header"></h2> 96 <h2 class="i18n_options_acceptableAds_header"></h2>
97 <p class="i18n_options_acceptableAds_description"></p> 97 <p class="i18n_options_acceptableAds_description"></p>
98 </header> 98 </header>
99 <form id="acceptable-ads"> 99 <form id="acceptable-ads">
100 <div> 100 <ul>
101 <input data-action="switch-acceptable-ads" type="radio" name="acce ptable-ads" value="ads"> 101 <li>
102 <label class="i18n_options_acceptableAds_ads_label"></label> 102 <button id="acceptable-ads-allow" data-action="switch-acceptable -ads" type="button" role="checkbox" name="acceptable-ads" value="ads"></button>
103 <p id="enable-aa-description" class="i18n_options_acceptableAds_ad s_description_1"></p> 103 <label for="acceptable-ads-allow" class="i18n_options_acceptable Ads_ads_label"></label>
104 <p class="i18n_options_acceptableAds_ads_description_2"></p> 104 <p id="enable-acceptable-ads-description" class="i18n_options_ac ceptableAds_ads_description_1"></p>
105 </div> 105 <p class="i18n_options_acceptableAds_ads_description_2"></p>
106 <div> 106 </li>
107 <input data-action="switch-acceptable-ads" type="radio" name="acce ptable-ads" value="privacy"> 107 <ul>
108 <label class="i18n_options_acceptableAds_privacy_label"></label> 108 <li>
109 <p class="i18n_options_acceptableAds_privacy_description"></p> 109 <button id="acceptable-ads-privacy-allow" data-action="switch- acceptable-ads" type="button" role="checkbox" name="acceptable-ads" value="priva cy"></button>
110 <p id="dnt" class="i18n_options_acceptableAds_dnt_notification"></ p> 110 <label for="acceptable-ads-privacy-allow" class="i18n_options_ acceptableAds_privacy_label"></label>
111 </div> 111 <a id="enable-acceptable-ads-privacy-description">
112 <div> 112 <p class="i18n_options_acceptableAds_privacy_description"></ p>
113 <input data-action="switch-acceptable-ads" type="radio" name="acce ptable-ads" value="none"> 113 </a>
Thomas Greiner 2017/10/20 15:35:03 Detail: We don't want to hyperlink the entire bloc
saroyanm 2017/10/20 16:42:06 Done, I'll fix wording and section in separate iss
114 <label class="i18n_options_acceptableAds_none_label"></label> 114 <p id="dnt" class="i18n_options_acceptableAds_dnt_notification "></p>
115 </div> 115 </li>
116 </ul>
117 </ul>
116 </form> 118 </form>
117 </section> 119 </section>
118 <section class="cols"> 120 <section class="cols">
119 <header> 121 <header>
120 <h2 class="i18n_options_language_header"></h2> 122 <h2 class="i18n_options_language_header"></h2>
121 <p class="i18n_options_language_description"></p> 123 <p class="i18n_options_language_description"></p>
122 </header> 124 </header>
123 <div id="blocking-languages"> 125 <div id="blocking-languages">
124 <ul id="blocking-languages-table" class="table list"> 126 <ul id="blocking-languages-table" class="table list">
125 <template> 127 <template>
(...skipping 272 matching lines...) Expand 10 before | Expand all | Expand 10 after
398 </div> 400 </div>
399 <!-- Notification --> 401 <!-- Notification -->
400 <div id="notification" aria-hidden="true" aria-live="polite"> 402 <div id="notification" aria-hidden="true" aria-live="polite">
401 <strong id="notification-text"></strong> 403 <strong id="notification-text"></strong>
402 <button id="hide-notification" data-action="hide-notification"> 404 <button id="hide-notification" data-action="hide-notification">
403 <span class="i18n_options_notification_hide sr-only"></span> 405 <span class="i18n_options_notification_hide sr-only"></span>
404 </button> 406 </button>
405 </div> 407 </div>
406 </body> 408 </body>
407 </html> 409 </html>
OLDNEW
« no previous file with comments | « no previous file | desktop-options.js » ('j') | desktop-options.js » ('J')

Powered by Google App Engine
This is Rietveld