Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: skin/desktop-options.css

Issue 29578574: Issue 5632 - Use checkboxes for toggling acceptable ads (Closed)
Left Patch Set: Created Oct. 16, 2017, 5:36 p.m.
Right Patch Set: Fixed the duplication Created Oct. 20, 2017, 6:56 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « desktop-options.js ('k') | no next file » | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-present eyeo GmbH 3 * Copyright (C) 2006-present eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 156 matching lines...) Expand 10 before | Expand all | Expand 10 after
167 { 167 {
168 background-image: url(icons/checkbox.png); 168 background-image: url(icons/checkbox.png);
169 display: inline-block; 169 display: inline-block;
170 } 170 }
171 171
172 button[role="checkbox"][aria-checked="true"]:not(.toggle) 172 button[role="checkbox"][aria-checked="true"]:not(.toggle)
173 { 173 {
174 background-position: 0px 18px; 174 background-position: 0px 18px;
175 } 175 }
176 176
177 button[role="checkbox"][disabled] 177 button[role="checkbox"][disabled],
178 button[role="checkbox"][aria-disabled="true"]
178 { 179 {
179 border-radius: 2px; 180 border-radius: 2px;
180 background-color: #ccc; 181 background-color: #ccc;
181 } 182 }
182 183
183 button[role="checkbox"].toggle 184 button[role="checkbox"].toggle
184 { 185 {
185 background: url(icons/toggle.svg#on); 186 background: url(icons/toggle.svg#on);
186 } 187 }
187 188
(...skipping 434 matching lines...) Expand 10 before | Expand all | Expand 10 after
622 Acceptable ads 623 Acceptable ads
623 */ 624 */
624 625
625 #acceptable-ads ul 626 #acceptable-ads ul
626 { 627 {
627 position: relative; 628 position: relative;
628 padding-left: 2rem; 629 padding-left: 2rem;
629 list-style: none; 630 list-style: none;
630 } 631 }
631 632
632 #acceptable-ads ul li button 633 html[dir="rtl"] #acceptable-ads ul
ire 2017/10/17 08:16:34 NIT: This may not be to be so specific. `#acceptab
saroyanm 2017/10/17 19:23:07 Done.
saroyanm 2017/10/17 19:23:08 Done.
634 {
635 padding-left: 0rem;
636 padding-right: 2rem;
637 }
638
639 #acceptable-ads button
633 { 640 {
634 position: absolute; 641 position: absolute;
635 margin-top: 0.3rem; 642 margin-top: 0.3rem;
636 left: 0rem; 643 left: 0rem;
ire 2017/10/17 08:16:34 The checkbox is still on the left when direction i
saroyanm 2017/10/17 19:23:07 Done.
637 } 644 }
638 645
639 #acceptable-ads ul li label 646 html[dir="rtl"] button
ire 2017/10/17 08:16:34 NIT: Same here. Suggest: `#acceptable-ads label`
saroyanm 2017/10/17 19:23:07 Done.
saroyanm 2017/10/17 19:23:07 Done.
647 {
648 left: auto;
649 right: 0rem;
650 }
651
652 #acceptable-ads label
640 { 653 {
641 font-weight: 700; 654 font-weight: 700;
642 font-size: 1.375rem; 655 font-size: 1.375rem;
643 } 656 }
644 657
645 #dnt 658 #dnt
646 { 659 {
647 padding: 0.8rem; 660 padding: 0.8rem;
648 border: 1px solid #099CD0; 661 border: 1px solid #099CD0;
649 }
650
651 .new
ire 2017/10/17 08:16:34 In the spec, this text is uppercase. Also, it seem
saroyanm 2017/10/17 19:23:07 I used the styles that match the old design here -
652 {
653 display: inline-block;
654 margin: 0rem 0.5rem;
655 padding: 0.3rem 0.5rem;
656 border-radius: 0.2rem;
657 background-color: #099CD0;
658 color: #FFF;
659 line-height: 100%;
660 font-size: 1rem;
661 } 662 }
662 663
663 /* 664 /*
664 Tables 665 Tables
665 */ 666 */
666 667
667 ul.table, 668 ul.table,
668 ul.list 669 ul.list
669 { 670 {
670 list-style: none; 671 list-style: none;
(...skipping 774 matching lines...) Expand 10 before | Expand all | Expand 10 after
1445 1446
1446 #hide-notification::after 1447 #hide-notification::after
1447 { 1448 {
1448 background-color: #099DD1; 1449 background-color: #099DD1;
1449 } 1450 }
1450 1451
1451 #hide-notification:hover::after 1452 #hide-notification:hover::after
1452 { 1453 {
1453 background-color: #5CBCE1; 1454 background-color: #5CBCE1;
1454 } 1455 }
LEFTRIGHT

Powered by Google App Engine
This is Rietveld