Delta Between Two Patch Sets: desktop-options.html
Issue 29578574:
Issue 5632 - Use checkboxes for toggling acceptable ads (Closed)
Left Patch Set: Addressed Ire's comments
Created Oct. 19, 2017, 8:40 p.m.
Right Patch Set: Fixed the duplication
Created Oct. 20, 2017, 6:56 p.m.
| Left: | ||
| Right: |
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with change/comment
|
« no previous file
|
desktop-options.js » ('j')
|
no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| LEFT | RIGHT |
|---|---|
| 1 <!DOCTYPE html> | 1 <!DOCTYPE html> |
| 2 <!-- | 2 <!-- |
| 3 - This file is part of Adblock Plus <https://adblockplus.org/>, | 3 - This file is part of Adblock Plus <https://adblockplus.org/>, |
| 4 - Copyright (C) 2006-present eyeo GmbH | 4 - Copyright (C) 2006-present eyeo GmbH |
| 5 - | 5 - |
| 6 - Adblock Plus is free software: you can redistribute it and/or modify | 6 - Adblock Plus is free software: you can redistribute it and/or modify |
| 7 - it under the terms of the GNU General Public License version 3 as | 7 - it under the terms of the GNU General Public License version 3 as |
| 8 - published by the Free Software Foundation. | 8 - published by the Free Software Foundation. |
| 9 - | 9 - |
| 10 - Adblock Plus is distributed in the hope that it will be useful, | 10 - Adblock Plus is distributed in the hope that it will be useful, |
| (...skipping 90 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 101 <li> | 101 <li> |
| 102 <button id="acceptable-ads-allow" data-action="switch-acceptable -ads" type="button" role="checkbox" name="acceptable-ads" value="ads"></button> | 102 <button id="acceptable-ads-allow" data-action="switch-acceptable -ads" type="button" role="checkbox" name="acceptable-ads" value="ads"></button> |
| 103 <label for="acceptable-ads-allow" class="i18n_options_acceptable Ads_ads_label"></label> | 103 <label for="acceptable-ads-allow" class="i18n_options_acceptable Ads_ads_label"></label> |
| 104 <p id="enable-acceptable-ads-description" class="i18n_options_ac ceptableAds_ads_description_1"></p> | 104 <p id="enable-acceptable-ads-description" class="i18n_options_ac ceptableAds_ads_description_1"></p> |
| 105 <p class="i18n_options_acceptableAds_ads_description_2"></p> | 105 <p class="i18n_options_acceptableAds_ads_description_2"></p> |
| 106 </li> | 106 </li> |
| 107 <ul> | 107 <ul> |
| 108 <li> | 108 <li> |
| 109 <button id="acceptable-ads-privacy-allow" data-action="switch- acceptable-ads" type="button" role="checkbox" name="acceptable-ads" value="priva cy"></button> | 109 <button id="acceptable-ads-privacy-allow" data-action="switch- acceptable-ads" type="button" role="checkbox" name="acceptable-ads" value="priva cy"></button> |
| 110 <label for="acceptable-ads-privacy-allow" class="i18n_options_ acceptableAds_privacy_label"></label> | 110 <label for="acceptable-ads-privacy-allow" class="i18n_options_ acceptableAds_privacy_label"></label> |
| 111 <a id="enable-acceptable-ads-privacy-description"> | 111 <p> |
| 112 <p class="i18n_options_acceptableAds_privacy_description"></ p> | 112 <a id="enable-acceptable-ads-privacy-description" class="i18 n_options_acceptableAds_privacy_description"></a> |
| 113 </a> | 113 </p> |
|
Thomas Greiner
2017/10/20 15:35:03
Detail: We don't want to hyperlink the entire bloc
saroyanm
2017/10/20 16:42:06
Done, I'll fix wording and section in separate iss
| |
| 114 <p id="dnt" class="i18n_options_acceptableAds_dnt_notification "></p> | 114 <p id="dnt" class="i18n_options_acceptableAds_dnt_notification "></p> |
| 115 </li> | 115 </li> |
| 116 </ul> | 116 </ul> |
| 117 </ul> | 117 </ul> |
| 118 </form> | 118 </form> |
| 119 </section> | 119 </section> |
| 120 <section class="cols"> | 120 <section class="cols"> |
| 121 <header> | 121 <header> |
| 122 <h2 class="i18n_options_language_header"></h2> | 122 <h2 class="i18n_options_language_header"></h2> |
| 123 <p class="i18n_options_language_description"></p> | 123 <p class="i18n_options_language_description"></p> |
| (...skipping 276 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 400 </div> | 400 </div> |
| 401 <!-- Notification --> | 401 <!-- Notification --> |
| 402 <div id="notification" aria-hidden="true" aria-live="polite"> | 402 <div id="notification" aria-hidden="true" aria-live="polite"> |
| 403 <strong id="notification-text"></strong> | 403 <strong id="notification-text"></strong> |
| 404 <button id="hide-notification" data-action="hide-notification"> | 404 <button id="hide-notification" data-action="hide-notification"> |
| 405 <span class="i18n_options_notification_hide sr-only"></span> | 405 <span class="i18n_options_notification_hide sr-only"></span> |
| 406 </button> | 406 </button> |
| 407 </div> | 407 </div> |
| 408 </body> | 408 </body> |
| 409 </html> | 409 </html> |
| LEFT | RIGHT |
« no previous file
|
desktop-options.js » ('j')
|
Toggle Intra-line Diffs ('i')
|
Expand Comments ('e')
|
Collapse Comments ('c')
|
Toggle Comments ('s')
