Unified Diff: skin/desktop-options.css
Issue 29578574:
Issue 5632 - Use checkboxes for toggling acceptable ads (Closed)
Patch Set:
Created Oct. 16, 2017, 5:36 p.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« desktop-options.js ('K')
|
« locale/en_US/desktop-options.json ('k')
|
no next file »
|
no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: skin/desktop-options.css |
| =================================================================== |
| --- a/skin/desktop-options.css |
| +++ b/skin/desktop-options.css |
| @@ -622,41 +622,21 @@ |
| Acceptable ads |
| */ |
| -#acceptable-ads |
| +#acceptable-ads ul |
| { |
| - background-color: #F3F3F3; |
| + position: relative; |
| + padding-left: 2rem; |
| + list-style: none; |
| } |
| -#acceptable-ads > div |
| +#acceptable-ads ul li button |
|
ire
2017/10/17 08:16:34
NIT: This may not be to be so specific. `#acceptab
saroyanm
2017/10/17 19:23:07
Done.
saroyanm
2017/10/17 19:23:08
Done.
|
| { |
| - position: relative; |
| - padding: 1.5rem; |
| - padding-left: 3.3rem; |
| - padding-right: 0.9rem; |
| - border: 1px solid #CDCDCD; |
| - border-width: 0px 1px 1px 1px; |
| + position: absolute; |
| + margin-top: 0.3rem; |
| + left: 0rem; |
|
ire
2017/10/17 08:16:34
The checkbox is still on the left when direction i
saroyanm
2017/10/17 19:23:07
Done.
|
| } |
| -#acceptable-ads > div:first-of-type |
| -{ |
| - border-top: 1px solid #CDCDCD; |
| -} |
| - |
| -#acceptable-ads > div > p:last-of-type |
| -{ |
| - margin-bottom: 0rem; |
| -} |
| - |
| -#acceptable-ads > div input |
| -{ |
| - position: absolute; |
| - left: 0rem; |
| - margin: 0.25rem 0.9rem; |
| - width: 1.3rem; |
| - height: 1.3rem; |
| -} |
| - |
| -#acceptable-ads > div label |
| +#acceptable-ads ul li label |
|
ire
2017/10/17 08:16:34
NIT: Same here.
Suggest: `#acceptable-ads label`
saroyanm
2017/10/17 19:23:07
Done.
saroyanm
2017/10/17 19:23:07
Done.
|
| { |
| font-weight: 700; |
| font-size: 1.375rem; |
| @@ -668,6 +648,18 @@ |
| border: 1px solid #099CD0; |
| } |
| +.new |
|
ire
2017/10/17 08:16:34
In the spec, this text is uppercase. Also, it seem
saroyanm
2017/10/17 19:23:07
I used the styles that match the old design here -
|
| +{ |
| + display: inline-block; |
| + margin: 0rem 0.5rem; |
| + padding: 0.3rem 0.5rem; |
| + border-radius: 0.2rem; |
| + background-color: #099CD0; |
| + color: #FFF; |
| + line-height: 100%; |
| + font-size: 1rem; |
| +} |
| + |
| /* |
| Tables |
| */ |
« desktop-options.js ('K')
|
« locale/en_US/desktop-options.json ('k')
|
no next file »
|
no next file with comments »
