Issue 5174 - Allow '{' and '}' in selectors

test/filterClasses.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 49 matching lines @@
     ["@@/asdf??+/", InvalidFilter, "invalid"],
     ["##asdf", ElemHideFilter, "elemhide"],
     ["#@#asdf", ElemHideException, "elemhideexception"],
     ["foobar##asdf", ElemHideFilter, "elemhide"],
     ["foobar#@#asdf", ElemHideException, "elemhideexception"],
     ["foobar##a", ElemHideFilter, "elemhide"],
     ["foobar#@#a", ElemHideException, "elemhideexception"],
 
     ["foobar#asdf", BlockingFilter, "blocking"],
     ["foobar|foobas##asdf", BlockingFilter, "blocking"],
-    ["foobar##asdf{asdf}", BlockingFilter, "blocking"],
+    ["foobar##asdf{asdf}", ElemHideFilter, "elemhide"],
     ["foobar##", BlockingFilter, "blocking"],
     ["foobar#@#", BlockingFilter, "blocking"],
     ["asdf$foobar", InvalidFilter, "invalid"],
     ["asdf$image,foobar", InvalidFilter, "invalid"],
     ["asdf$image=foobar", BlockingFilter, "blocking"],
     ["asdf$image=foobar=xyz,~collapse", BlockingFilter, "blocking"],
 
     ["##foo[-abp-properties='something']bar", InvalidFilter, "invalid"],
     ["#@#foo[-abp-properties='something']bar", ElemHideException, "elemhideexception"],
     ["example.com##foo[-abp-properties='something']bar", ElemHideEmulationFilter, "elemhideemulation"],
@@ skipping 293 matching lines @@
 
   for (let [text, selector, selectorDomain] of tests)
   {
     doTest(text, selector, selectorDomain);
     doTest(text.replace("##", "#@#"), selector, selectorDomain);
   }
 
   test.done();
 };
 
+exports.testElemHideRulesWithBraces = function(test)
+{
+  let filter = Filter.fromText("###foo{color: red}");
+  test.equal(filter.type, "elemhide");
+  test.equal(filter.selector, "#foo\\x7B color: red\\x7D ");
+  filter.delete();
+
+  filter = Filter.fromText("foo.com##[-abp-properties='/margin: [3-4]{2}/']");

[hub, 2017/10/16 18:39:43]

we don't handle the new syntax yet.

[Wladimir Palant, 2017/10/17 10:24:33]

Feel free to file an issue for that.

[hub, 2017/10/17 19:22:18]

Filed https://issues.adblockplus.org/ticket/5870

+  test.equal(filter.type, "elemhideemulation");
+  test.equal(filter.selector, "[-abp-properties='/margin: [3-4]\\x7B 2\\x7D /']");
+  filter.delete();
+
+  test.done();
+};
+
 exports.testNotifications = function(test)
 {
   function checkNotifications(action, expected, message)
   {
     let result = null;
     let listener = (topic, filter) =>
     {
       if (result)
         test.ok(false, "Got more that one notification - " + message);
       else
@@ skipping 37 matching lines @@
     filter.hitCount++;
   }, ["filter.hitCount", "foobar"], "Increasing filter hit counts");
   checkNotifications(() =>
   {
     filter.hitCount = 0;
   }, ["filter.hitCount", "foobar"], "Resetting filter hit counts");
 
   filter.delete();
   test.done();
 };