Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29581588: Issue 5258 - Add typedefs for smart pointers referring to all filter and subscription classes (Closed)

Created:
Oct. 17, 2017, 12:27 p.m. by Wladimir Palant
Modified:
Dec. 21, 2017, 10:52 a.m.
Reviewers:
sergei, hub
CC:
Felix Dahlke
Base URL:
https://hg.adblockplus.org/adblockpluscore
Visibility:
Public.

Description

Issue 5258 - Add typedefs for smart pointers referring to all filter and subscription classes

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -0 lines) Patch
M compiled/filter/ActiveFilter.h View 1 chunk +2 lines, -0 lines 0 comments Download
M compiled/filter/BlockingFilter.h View 1 chunk +2 lines, -0 lines 0 comments Download
M compiled/filter/CommentFilter.h View 1 chunk +2 lines, -0 lines 0 comments Download
M compiled/filter/ElemHideBase.h View 1 chunk +2 lines, -0 lines 0 comments Download
M compiled/filter/ElemHideEmulationFilter.h View 1 chunk +2 lines, -0 lines 0 comments Download
M compiled/filter/ElemHideException.h View 1 chunk +2 lines, -0 lines 0 comments Download
M compiled/filter/ElemHideFilter.h View 1 chunk +2 lines, -0 lines 0 comments Download
M compiled/filter/InvalidFilter.h View 1 chunk +2 lines, -0 lines 0 comments Download
M compiled/filter/RegExpFilter.h View 1 chunk +2 lines, -0 lines 0 comments Download
M compiled/filter/WhitelistFilter.h View 1 chunk +2 lines, -0 lines 0 comments Download
M compiled/subscription/DownloadableSubscription.h View 1 chunk +2 lines, -0 lines 0 comments Download
M compiled/subscription/UserDefinedSubscription.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 3
Wladimir Palant
Oct. 17, 2017, 12:27 p.m. (2017-10-17 12:27:29 UTC) #1
hub
LGTM
Oct. 17, 2017, 12:56 p.m. (2017-10-17 12:56:42 UTC) #2
sergei
Oct. 17, 2017, 1:10 p.m. (2017-10-17 13:10:09 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld