Side by Side Diff: static/scss/_base.scss
Issue 29581874:
Noissue - Removed website-default container widths (Closed)
Base URL: https://hg.adblockplus.org/website-defaults
Patch Set:
Created Oct. 17, 2017, 3:13 p.m.
| Left: | ||
| Right: |
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with comments
|
« no previous file
|
static/scss/_variables.scss » ('j')
|
no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| OLD | NEW |
|---|---|
| 1 // This file is part of website-defaults | 1 // This file is part of website-defaults |
| 2 // Copyright (C) 2016-present eyeo GmbH | 2 // Copyright (C) 2016-present eyeo GmbH |
| 3 // | 3 // |
| 4 // website-defaults is free software: you can redistribute it and/or | 4 // website-defaults is free software: you can redistribute it and/or |
| 5 // modify it under the terms of the GNU General Public License as published by | 5 // modify it under the terms of the GNU General Public License as published by |
| 6 // the Free Software Foundation, either version 3 of the License, or | 6 // the Free Software Foundation, either version 3 of the License, or |
| 7 // (at your option) any later version. | 7 // (at your option) any later version. |
| 8 // | 8 // |
| 9 // website-defaults is distributed in the hope that it will be useful, | 9 // website-defaults is distributed in the hope that it will be useful, |
| 10 // but WITHOUT ANY WARRANTY; without even the implied warranty of | 10 // but WITHOUT ANY WARRANTY; without even the implied warranty of |
| (...skipping 23 matching lines...) Expand all Loading... | |
| 34 display: block; | 34 display: block; |
| 35 width: 100%; | 35 width: 100%; |
| 36 margin: $small-space 0px; | 36 margin: $small-space 0px; |
| 37 } | 37 } |
| 38 | 38 |
| 39 /** | 39 /** |
| 40 * Center content within a (responsive) fixed width | 40 * Center content within a (responsive) fixed width |
| 41 */ | 41 */ |
| 42 .container | 42 .container |
| 43 { | 43 { |
| 44 width: $phone-width; | 44 width: $container-max-width; |
|
ire
2017/10/17 17:34:37
Since this is being applied to width, I think the
juliandoucette
2017/10/18 13:27:28
Acknowledged.
| |
| 45 max-width: 100%; | 45 max-width: 100%; |
| 46 margin: 0px auto; | 46 margin: 0px auto; |
| 47 padding: 0px $small-space; | 47 padding: 0px $small-space; |
|
ire
2017/10/17 17:34:37
NIT: I think this space should be larger on bigger
juliandoucette
2017/10/18 13:27:28
Acknowledged.
juliandoucette
2017/10/18 13:44:33
I'm skeptical about $tablet-breakpoint because it'
| |
| 48 } | 48 } |
| 49 | 49 |
| 50 @media(min-width: $tablet-breakpoint) | |
| 51 { | |
| 52 .container | |
| 53 { | |
| 54 width: $tablet-width; | |
| 55 } | |
| 56 } | |
| 57 | |
| 58 @media(min-width: $desktop-breakpoint) | |
| 59 { | |
| 60 .container | |
| 61 { | |
| 62 width: $desktop-width; | |
| 63 } | |
| 64 } | |
| 65 | |
| 66 @media(min-width: $large-desktop-breakpoint) | |
| 67 { | |
| 68 .container | |
| 69 { | |
| 70 width: $large-desktop-width; | |
| 71 } | |
| 72 } | |
| 73 | |
| 74 .clearfix:after, | 50 .clearfix:after, |
| 75 .clearfix:before | 51 .clearfix:before |
| 76 { | 52 { |
| 77 display: table; | 53 display: table; |
| 78 content: " "; | 54 content: " "; |
| 79 } | 55 } |
| 80 | 56 |
| 81 .clearfix:after | 57 .clearfix:after |
| 82 { | 58 { |
| 83 clear: both; | 59 clear: both; |
| 84 } | 60 } |
| OLD | NEW |
« no previous file with comments
|
« no previous file
|
static/scss/_variables.scss » ('j')
|
no next file with comments »
