Side by Side Diff: static/scss/_variables.scss
Issue 29581874:
Noissue - Removed website-default container widths (Closed)
Base URL: https://hg.adblockplus.org/website-defaults
Patch Set: Addressed comments
Created Oct. 18, 2017, 1:37 p.m.
| Left: | ||
| Right: |
Use n/p to move between diff chunks;
N/P to move between comments.
« static/scss/_base.scss ('K')
|
« static/scss/_base.scss ('k')
|
no next file »
|
no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| OLD | NEW |
|---|---|
| 1 // This file is part of website-defaults | 1 // This file is part of website-defaults |
| 2 // Copyright (C) 2016-present eyeo GmbH | 2 // Copyright (C) 2016-present eyeo GmbH |
| 3 // | 3 // |
| 4 // website-defaults is free software: you can redistribute it and/or | 4 // website-defaults is free software: you can redistribute it and/or |
| 5 // modify it under the terms of the GNU General Public License as published by | 5 // modify it under the terms of the GNU General Public License as published by |
| 6 // the Free Software Foundation, either version 3 of the License, or | 6 // the Free Software Foundation, either version 3 of the License, or |
| 7 // (at your option) any later version. | 7 // (at your option) any later version. |
| 8 // | 8 // |
| 9 // website-defaults is distributed in the hope that it will be useful, | 9 // website-defaults is distributed in the hope that it will be useful, |
| 10 // but WITHOUT ANY WARRANTY; without even the implied warranty of | 10 // but WITHOUT ANY WARRANTY; without even the implied warranty of |
| (...skipping 68 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 79 //////////////////////////////////////////////////////////////////////////////// | 79 //////////////////////////////////////////////////////////////////////////////// |
| 80 | 80 |
| 81 // Device breakpoints | 81 // Device breakpoints |
| 82 | 82 |
| 83 $phone-breakpoint: 320px !default; | 83 $phone-breakpoint: 320px !default; |
| 84 $phablet-breakpoint: 576px !default; | 84 $phablet-breakpoint: 576px !default; |
| 85 $tablet-breakpoint: 768px !default; | 85 $tablet-breakpoint: 768px !default; |
| 86 $desktop-breakpoint: 992px !default; | 86 $desktop-breakpoint: 992px !default; |
| 87 $large-desktop-breakpoint: 1200px !default; | 87 $large-desktop-breakpoint: 1200px !default; |
| 88 | 88 |
| 89 // Grid breakpoints | 89 // Device widths |
|
ire
2017/10/20 07:49:39
Why were these removed? The variables are still be
juliandoucette
2017/10/20 11:05:11
I didn't remove these manually - which means I for
| |
| 90 | |
| 91 $half-breakpoint: $tablet-breakpoint !default; | |
| 92 $third-breakpoint: $desktop-breakpoint !default; | |
| 93 $fourth-breakpoint: $desktop-breakpoint !default; | |
| 94 | |
| 95 // Container widths | |
| 96 //////////////////////////////////////////////////////////////////////////////// | 90 //////////////////////////////////////////////////////////////////////////////// |
| 97 | 91 |
| 98 $phone-width: auto !default; | 92 $phone-width: auto !default; |
| 99 $phablet-width: 540px !default; | 93 $phablet-width: 540px !default; |
| 100 $tablet-width: 720px !default; | 94 $tablet-width: 720px !default; |
| 101 $desktop-width: 960px !default; | 95 $desktop-width: 960px !default; |
| 102 $large-desktop-width: 1140px !default; | 96 $large-desktop-width: 1140px !default; |
| OLD | NEW |
« static/scss/_base.scss ('K')
|
« static/scss/_base.scss ('k')
|
no next file »
|
no next file with comments »
