static/scss/_base.scss - Issue 29581874: Noissue - Removed website-default container widths

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: static/scss/_base.scss

Issue 29581874: Noissue - Removed website-default container widths (Closed) Base URL: https://hg.adblockplus.org/website-defaults

Left Patch Set: Fixed mistakes Created Oct. 20, 2017, 11:11 a.m.

Right Patch Set: Addressed comments Created Oct. 23, 2017, 12:58 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 // This file is part of website-defaults	1 // This file is part of website-defaults

2 // Copyright (C) 2016-present eyeo GmbH	2 // Copyright (C) 2016-present eyeo GmbH

3 //	3 //

4 // website-defaults is free software: you can redistribute it and/or	4 // website-defaults is free software: you can redistribute it and/or

5 // modify it under the terms of the GNU General Public License as published by	5 // modify it under the terms of the GNU General Public License as published by

6 // the Free Software Foundation, either version 3 of the License, or	6 // the Free Software Foundation, either version 3 of the License, or

7 // (at your option) any later version.	7 // (at your option) any later version.

8 //	8 //

9 // website-defaults is distributed in the hope that it will be useful,	9 // website-defaults is distributed in the hope that it will be useful,

10 // but WITHOUT ANY WARRANTY; without even the implied warranty of	10 // but WITHOUT ANY WARRANTY; without even the implied warranty of

(...skipping 15 matching lines...) Expand all Loading...
26 line-height: 1.5;	26 line-height: 1.5;

27 }	27 }

28	28

29 /**	29 /**

30 * Center content within a (responsive) fixed width	30 * Center content within a (responsive) fixed width

31 */	31 */

32 .container	32 .container

33 {	33 {

34 width: $container-width;	34 width: $container-width;

35 max-width: 100%;	35 max-width: 100%;

	36 margin-right: auto;

36 margin-left: auto;	37 margin-left: auto;

37 margin-right: auto;	38 padding-right: $small-space;
ire 2017/10/23 11:59:37 margin-right should come before margin-left (same margin-right should come before margin-left (same for padding) according to our coding style juliandoucette 2017/10/23 12:45:49 Done. Show quoted text On 2017/10/23 11:59:37, ire wrote: > margin-right should come before margin-left (same for padding) according to our > coding style Done.
38 padding-left: $small-space;	39 padding-left: $small-space;

39 padding-right: $small-space;

40 }	40 }

LEFT	RIGHT