Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29581878: Noissue - Moved website-default grid variables to variables (Closed)

Created:
Oct. 17, 2017, 3:15 p.m. by juliandoucette
Modified:
Oct. 18, 2017, 12:34 p.m.
Reviewers:
ire
Base URL:
https://hg.adblockplus.org/website-defaults
Visibility:
Public.

Description

I don't remember if we discussed this before. Anyway, I think that component specific variables could get confusing fast. Let me know what you think.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M static/scss/_grid.scss View 1 chunk +0 lines, -4 lines 0 comments Download
M static/scss/_variables.scss View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 3
juliandoucette
Oct. 17, 2017, 3:15 p.m. (2017-10-17 15:15:54 UTC) #1
ire
> I don't remember if we discussed this before. Anyway, I think that component specific ...
Oct. 18, 2017, 8 a.m. (2017-10-18 08:00:16 UTC) #2
juliandoucette
Oct. 18, 2017, 12:33 p.m. (2017-10-18 12:33:57 UTC) #3

Powered by Google App Engine
This is Rietveld