Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29582640: Noissue - Add support for large-desktop-width to help center (Closed)

Created:
Oct. 18, 2017, 1:55 p.m. by juliandoucette
Modified:
Oct. 24, 2017, 12:23 p.m.
Reviewers:
ire
CC:
jeen, martin
Base URL:
https://hg.adblockplus.org/help.eyeo.com
Visibility:
Public.

Description

I don't have my hopes up for this one :D - But I wanted to suggest it, and making the change myself was as-fast. I think there may be a problem with the product page though. We could fit 3 or 4 columns. 2 columns looks a little stretched.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -13 lines) Patch
M includes/contact.html View 1 chunk +1 line, -1 line 0 comments Download
M static/scss/base/_variables.scss View 1 chunk +0 lines, -5 lines 0 comments Download
M static/scss/components/_contact.scss View 2 chunks +14 lines, -1 line 0 comments Download
M static/scss/layout/_body.scss View 1 chunk +0 lines, -5 lines 0 comments Download
M static/scss/layout/_navbar.scss View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6
juliandoucette
Oct. 18, 2017, 1:55 p.m. (2017-10-18 13:55:34 UTC) #1
juliandoucette
I created this prototype in response to the prospect of disabling large-desktop-width in help center. ...
Oct. 18, 2017, 1:58 p.m. (2017-10-18 13:58:16 UTC) #2
ire
> I think there may be a problem with the product page though. We could ...
Oct. 20, 2017, 8:28 a.m. (2017-10-20 08:28:50 UTC) #3
juliandoucette
On 2017/10/20 08:28:50, ire wrote: > I think we could support large-desktop-width as you've shown ...
Oct. 23, 2017, 2:13 p.m. (2017-10-23 14:13:53 UTC) #4
juliandoucette
On 2017/10/23 14:13:53, juliandoucette wrote: > Agreed. CC Jeen & Martin. > > Context: website-defaults ...
Oct. 24, 2017, 12:22 p.m. (2017-10-24 12:22:48 UTC) #5
juliandoucette
Oct. 24, 2017, 12:23 p.m. (2017-10-24 12:23:50 UTC) #6
On 2017/10/24 12:22:48, juliandoucette wrote:
> 
> From Jeen:
> 
> Hi Julian,
> 
> Thanks for the detailed explanation. I prefer the versions for "custom desktop
> 1.jpg" and "custom desktop 2.jpg" because it sits in a narrower container -
and
> when it comes to screen readability, the optimal article container width for
> users is 560-pixel. Using the default version moves further away from this
> value, making the page less easy to scan. 
> 
> Jeen

Ack. Closing this review then.

Powered by Google App Engine
This is Rietveld