Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(444)

Issue 29582667: Issue 5869 - Redirect for privacy friendly ads doc (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 4 months ago by f.nicolaisen
Modified:
2 years, 4 months ago
Reviewers:
mathias
Base URL:
https://hg1/infrastructure
Visibility:
Public.

Description

Issue 5869 - Redirect for privacy friendly ads doc See http://hub.eyeo.com/projects/ops/wiki/URL_Redirects

Patch Set 1 #

Total comments: 2

Patch Set 2 : move config snippet to eyeo.to #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M hiera/roles/web/redirect/adblockplus.yaml View 1 1 chunk +1 line, -0 lines 1 comment Download
M hiera/roles/web/redirect/eyeo.yaml View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4
f.nicolaisen
2 years, 4 months ago (2017-10-18 17:02:38 UTC) #1
mathias
https://codereview.adblockplus.org/29582667/diff/29582668/hiera/roles/web/redirect/adblockplus.yaml File hiera/roles/web/redirect/adblockplus.yaml (right): https://codereview.adblockplus.org/29582667/diff/29582668/hiera/roles/web/redirect/adblockplus.yaml#newcode7 hiera/roles/web/redirect/adblockplus.yaml:7: privacy-friendly-ads: "https://adblockplus.org/en/acceptable-ads#privacy" This should be part of the eyeo.to ...
2 years, 4 months ago (2017-10-18 17:10:08 UTC) #2
f.nicolaisen
https://codereview.adblockplus.org/29582667/diff/29582668/hiera/roles/web/redirect/adblockplus.yaml File hiera/roles/web/redirect/adblockplus.yaml (right): https://codereview.adblockplus.org/29582667/diff/29582668/hiera/roles/web/redirect/adblockplus.yaml#newcode7 hiera/roles/web/redirect/adblockplus.yaml:7: privacy-friendly-ads: "https://adblockplus.org/en/acceptable-ads#privacy" On 2017/10/18 17:10:08, mathias wrote: > This ...
2 years, 4 months ago (2017-10-18 17:24:12 UTC) #3
mathias
2 years, 4 months ago (2017-10-18 17:31:25 UTC) #4
LGTM. See my remark though.

https://codereview.adblockplus.org/29582667/diff/29582670/hiera/roles/web/red...
File hiera/roles/web/redirect/adblockplus.yaml (right):

https://codereview.adblockplus.org/29582667/diff/29582670/hiera/roles/web/red...
hiera/roles/web/redirect/adblockplus.yaml:6: 
Unrelated change adding a line of whitespace is unrelated.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5