Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29582689: Noissue - Fix the escaping of '{' and '}' in CSS selectors (Closed)

Created:
Oct. 18, 2017, 6:42 p.m. by hub
Modified:
Oct. 18, 2017, 7:52 p.m.
Reviewers:
Wladimir Palant
Base URL:
https://hg.adblockplus.org/adblockpluscore/
Visibility:
Public.

Description

Noissue - Fix the escaping of '{' and '}' in CSS selectors

Patch Set 1 #

Patch Set 2 : Also update the content script #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M lib/content/elemHideEmulation.js View 1 1 chunk +1 line, -1 line 0 comments Download
M lib/filterClasses.js View 1 chunk +1 line, -1 line 0 comments Download
M test/browser/elemHideEmulation.js View 1 1 chunk +2 lines, -2 lines 0 comments Download
M test/filterClasses.js View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5
hub
Oct. 18, 2017, 6:42 p.m. (2017-10-18 18:42:52 UTC) #1
hub
As per https://issues.adblockplus.org/ticket/5174#comment:7
Oct. 18, 2017, 6:43 p.m. (2017-10-18 18:43:49 UTC) #2
Wladimir Palant
You need to adjust lib/content/elemHideEmulation.js as well.
Oct. 18, 2017, 7:14 p.m. (2017-10-18 19:14:56 UTC) #3
hub
content script as well.
Oct. 18, 2017, 7:40 p.m. (2017-10-18 19:40:44 UTC) #4
Wladimir Palant
Oct. 18, 2017, 7:42 p.m. (2017-10-18 19:42:12 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld