Issue 5354 - Adds handling for notifications on Opera

lib/notificationHelper.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 175 matching lines @@
     let texts = NotificationStorage.getLocalizedTexts(notification);
     let title = texts.title || "";
     let message = (texts.message || "").replace(/<\/?(a|strong)>/g, "");
     let iconUrl = ext.getURL("icons/detailed/abp-128.png");
     let linkCount = (activeNotification.links || []).length;
 
     if ("notifications" in chrome)
     {
       activeButtons = getNotificationButtons(activeNotification.type,
                                              texts.message);
-      chrome.notifications.create("", {
+      let options = {
         type: "basic",
         title,
         iconUrl,
         message,
         buttons: activeButtons.map(button => ({title: button.title})),
         // We use the highest priority to prevent the notification
         // from closing automatically.
         priority: 2
+      };
+      chrome.notifications.create("", options, () =>
+      {
+        if (chrome.runtime.lastError && chrome.runtime.lastError.message === `
+        Adding buttons to notifications is not supported.`)

[Sebastian Noack, 2017/10/21 21:04:28]

I would skip the check for the error message. If it failed for some reason, we
will just keep getting the same error again once we try without buttons.

But I would add a comment here, that on Opera buttons are not supported, causing
an error here.

[Jon Sonesen, 2017/10/30 22:41:41]

Done.

+        {
+          delete options.buttons;

[Jon Sonesen, 2017/10/19 21:59:17]

perhaps it is better to move this down or put all the logic in one control
statement?

[Sebastian Noack, 2017/10/21 21:04:28]

Yeah, I guess this operation makes more sense in the if-branch below.

[Jon Sonesen, 2017/10/30 22:41:41]

Done.

+          if (activeNotification.type != "question")
+            chrome.notifications.create("", options);
+        }
       });
     }
     else if ("Notification" in window && activeNotification.type != "question")
     {
       if (linkCount > 0)
         message += " " + ext.i18n.getMessage("notification_without_buttons");
 
       let widget = new Notification(
         title,
         {
@@ skipping 57 matching lines @@
   let methods = displayMethods[notificationType] || defaultDisplayMethods;
   return methods.includes(method);
 };
 
 ext.pages.onLoading.addListener(page =>
 {
   NotificationStorage.showNext(stringifyURL(page.url));
 });
 
 NotificationStorage.addShowListener(showNotification);