Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: lib/filterComposer.js

Issue 29584683: Noissue - Do not send composer.content.finished to newly opened tab (Closed) Base URL: https://hg.adblockplus.org/adblockpluschrome/
Patch Set: Created Oct. 20, 2017, 3:36 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/filterComposer.js
===================================================================
--- a/lib/filterComposer.js
+++ b/lib/filterComposer.js
@@ -263,10 +263,12 @@
port.on("composer.quoteCSS", (message, sender) =>
{
return quoteCSS(message.CSS);
});
ext.pages.onLoading.addListener(page =>
{
- page.sendMessage({type: "composer.content.finished"});
+ // A newly opened tab that is still loading has its URL set to about:blank
+ if (/^https?:/.test(page.url.protocol))
+ page.sendMessage({type: "composer.content.finished"});
});
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld