includes/components/navbar.html - Issue 29587584: Issue 5635 - Implement website-default navbar component

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: includes/components/navbar.html

Issue 29587584: Issue 5635 - Implement website-default navbar component (Closed) Base URL: https://hg.adblockplus.org/website-defaults

Patch Set: Created Oct. 24, 2017, 10:32 a.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <div class="navbar">
	juliandoucette 2017/10/26 15:55:55 suggest: navbar.tmpl (see template usage examples suggest: navbar.tmpl (see template usage examples below)
	2 <div class="container">
	juliandoucette 2017/10/26 15:55:54 NIT: I suggest we point out that .container is opt NIT: I suggest we point out that .container is optional via template comment {# #} juliandoucette 2017/10/26 15:58:01 This is inconsistent with my surrounding suggestio Show quoted text On 2017/10/26 15:55:54, juliandoucette wrote: > NIT: I suggest we point out that .container is optional via template comment {# > #} This is inconsistent with my surrounding suggestions. We could make this configurable, but I suggest we do that separately.
	3 <h1 class="navbar-branding">
	juliandoucette 2017/10/26 15:55:54 Note: I'm not sure that an h1 is appropriate Note: I'm not sure that an h1 is appropriate juliandoucette 2017/10/26 15:55:55 suggest: "navbar-brand" suggest: "navbar-brand"
	4 <a href="index">Website Defaults</a>
	juliandoucette 2017/10/26 15:55:55 suggest: make this more extensible e.g. {{ "index suggest: make this more extensible e.g. {{ "index" \| linkify }} {% if navbar_logo %} ... {% if navbar_logo_text %} ... </a>
	5 </h1>

	6

	7 <button class="toggle-navbar-collapse">
	juliandoucette 2017/10/26 15:55:55 suggest: "navbar-toggle" suggest: "navbar-toggle"
	8 <span class="open-label">Open</span>
	juliandoucette 2017/10/26 15:55:55 suggest: a shared hamberger icon suggest: a shared hamberger icon
	9 <span class="sr-only">/</span>

	10 <span class="close-label">Close</span>

	11 Menu

	12 </button>

	13
	juliandoucette 2017/10/26 15:55:55 suggest: enableable navbar search suggest: enableable navbar search
	14 <div class="navbar-collapse">

	15 <nav>

	16 <a href="index">Navbar Menu Link</a>
	juliandoucette 2017/10/26 15:55:55 suggest: loop an array of pages and external links suggest: loop an array of pages and external links juliandoucette 2017/10/26 15:55:55 suggest: More than one example link suggest: More than one example link
	17 </nav>

	18 </div>

	19 </div>
	juliandoucette 2017/10/26 15:55:54 suggest: enableable locale menu (separate include suggest: enableable locale menu (separate include - so that we could use it in the footer instead)
	20 </div>

OLD	NEW

« no previous file with comments | « no previous file | pages/index.html » ('j') | pages/navbar.md » ('J')