Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: static/js/navbar.js

Issue 29587584: Issue 5635 - Implement website-default navbar component (Closed) Base URL: https://hg.adblockplus.org/website-defaults
Patch Set: Demo of both methods Created Nov. 6, 2017, 8:18 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 /*******************************************************************************
2 * Navbar Component
juliandoucette 2017/11/06 12:36:43 BUG: You can't collapse the navbar if you expanded
ire 2017/11/08 17:14:46 I can't seem to reproduce this. If the navbar is o
juliandoucette 2017/11/09 14:34:51 Just re-tested. This only applied to the table lay
3 ******************************************************************************/
4
5 document.addEventListener("DOMContentLoaded", function()
6 {
7
8 function Navbar(navbar)
9 {
10 this.navbar = navbar;
11
12 this.navbar
13 .querySelector(".toggle-navbar-collapse button")
14 .addEventListener("click", this._onClick.bind(this), false);
15 }
16
17 Navbar.prototype.toggleCollapse = function()
18 {
19 this.navbar.classList.toggle("expanded");
20 };
21
22 Navbar.prototype._onClick = function()
23 {
24 this.toggleCollapse();
25 };
26
27 var navbars = document.getElementsByClassName("navbar");
28 for (var i = 0; i < navbars.length; i++)
29 {
30 new Navbar(navbars[i]);
31 }
32
33 }, false);
OLDNEW
« no previous file with comments | « pages/navbar.md ('k') | static/scss/_navbar.scss » ('j') | static/scss/_navbar.scss » ('J')

Powered by Google App Engine
This is Rietveld