Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Keyboard Shortcuts
File
u
:
up to issue
m
:
publish + mail comments
M
:
edit review message
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
<Enter>
:
respond to / edit current comment
d
:
mark current comment as done
Issue
u
:
up to list of issues
m
:
publish + mail comments
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
#
:
close issue
Comment/message editing
<Ctrl>
+
s
or
<Ctrl>
+
Enter
:
save comment
<Esc>
:
cancel edit
Rietveld
Code Review Tool
Help
|
Bug tracker
|
Discussion group
|
Source code
Issues
All Issues
Side by Side Diff: static/img/png/eyeo-logo.png
Issue
29587584
:
Issue 5635 - Implement website-default navbar component (Closed)
Base URL: https://hg.adblockplus.org/website-defaults
Patch Set: Use float method
Created Nov. 8, 2017, 5:13 p.m.
Left:
Base
Patch Set 1: None
Patch Set 2: Rebased
Patch Set 3: Demo - Use table layout
Patch Set 4: Demo of both methods
Patch Set 5: Use float method
Patch Set 6: Add navigation <ul> links
Patch Set 7: Addressed NITs
Patch Set 8: Use padding on navbar link, optimise svg
Patch Set 9: Remove separate open/close states
Patch Set 10: Variable for adding horizontal padding, link button class
Patch Set 11: Address scalability of navbar padding with logo size
Patch Set 12: Rebase
Right:
Patch Set 1: None
Patch Set 2: Rebased
Patch Set 3: Demo - Use table layout
Patch Set 4: Demo of both methods
Patch Set 5: Use float method
Patch Set 6: Add navigation <ul> links
Patch Set 7: Addressed NITs
Patch Set 8: Use padding on navbar link, optimise svg
Patch Set 9: Remove separate open/close states
Patch Set 10: Variable for adding horizontal padding, link button class
Patch Set 11: Address scalability of navbar padding with logo size
Patch Set 12: Rebase
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
includes/components/navbar.html
pages/index.html
pages/navbar.md
static/img/png/eyeo-logo.png
static/img/svg/eyeo-logo.svg
static/js/navbar.js
static/scss/_navbar.scss
static/scss/_utilities.scss
static/scss/_variables.scss
static/scss/forms/_buttons.scss
static/scss/main.scss
templates/default.tmpl
templates/minimal.tmpl
View unified diff
|
Download patch
« no previous file with comments
|
« pages/navbar.md
('k') |
static/img/svg/eyeo-logo.svg »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
OLD
NEW
« no previous file with comments
|
« pages/navbar.md
('k') |
static/img/svg/eyeo-logo.svg »
('j') |
no next file with comments »
Edit Message
Issue 29587584: Issue 5635 - Implement website-default navbar component (Closed)
Created Oct. 24, 2017, 10:32 a.m. by ire
Modified Jan. 9, 2018, 8 a.m.
Reviewers: juliandoucette
Base URL: https://hg.adblockplus.org/website-defaults
Comments: 155
This is Rietveld