| Left: | ||
| Right: |
| OLD | NEW |
|---|---|
| (Empty) | |
| 1 // This file is part of help.eyeo.com. | |
| 2 // Copyright (C) 2017 Eyeo GmbH | |
| 3 // | |
| 4 // help.eyeo.com is free software: you can redistribute it and/or modify | |
| 5 // it under the terms of the GNU General Public License as published by | |
| 6 // the Free Software Foundation, either version 3 of the License, or | |
| 7 // (at your option) any later version. | |
| 8 // | |
| 9 // help.eyeo.com is distributed in the hope that it will be useful, | |
| 10 // but WITHOUT ANY WARRANTY; without even the implied warranty of | |
| 11 // MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | |
| 12 // GNU General Public License for more details. | |
| 13 // | |
| 14 // You should have received a copy of the GNU General Public License | |
| 15 // along with help.eyeo.com. If not, see <http://www.gnu.org/licenses/>. | |
| 16 | |
| 17 /******************************************************************************* | |
| 18 * Navbar component | |
| 19 ******************************************************************************/ | |
| 20 | |
| 21 .navbar | |
| 22 { | |
| 23 @extend .clearfix; | |
| 24 } | |
| 25 | |
| 26 .toggle-navbar-collapse, | |
| 27 .navbar-collapse | |
| 28 { | |
| 29 padding-top: $navbar-padding-v + ($navbar-padding-v / 2); | |
|
juliandoucette
2017/11/10 11:42:52
I think that this assumes that .toggle-navbar-coll
ire
2017/11/13 17:57:42
You're right. The .toggle-navbar-collapse should a
| |
| 30 padding-bottom: $navbar-padding-v + ($navbar-padding-v / 2); | |
| 31 } | |
| 32 | |
| 33 /* .navbar .navbar-branding | |
| 34 ****************************************************************************/ | |
|
juliandoucette
2017/11/10 11:42:52
NIT: There is supposed to be one space before the
ire
2017/11/13 17:57:41
Done.
| |
| 35 | |
| 36 .navbar-branding | |
|
juliandoucette
2017/11/10 11:42:53
NIT/Suggest: Add padding-x to the navbar-branding
juliandoucette
2017/11/10 11:42:53
Suggest: Add a hover/active/focus background color
| |
| 37 { | |
| 38 padding-top: $navbar-padding-v; | |
| 39 padding-bottom: $navbar-padding-v; | |
| 40 } | |
| 41 | |
| 42 .navbar-branding img | |
| 43 { | |
| 44 height: $navbar-branding-height; | |
| 45 } | |
| 46 | |
| 47 /* .navbar .toggle-navbar-collapse | |
| 48 ****************************************************************************/ | |
| 49 | |
| 50 .toggle-navbar-collapse | |
|
juliandoucette
2017/11/10 11:42:52
TOL: Are these properties that should apply to `.u
ire
2017/11/13 17:57:42
Done.
| |
| 51 { | |
| 52 display: none; | |
| 53 border: 0; | |
| 54 background-color: transparent; | |
| 55 cursor: pointer; | |
| 56 } | |
| 57 | |
| 58 .js .toggle-navbar-collapse | |
| 59 { | |
| 60 display: block; | |
| 61 | |
| 62 @media (min-width: $tablet-breakpoint) | |
| 63 { | |
| 64 display: none; | |
| 65 } | |
| 66 } | |
| 67 | |
| 68 .js .toggle-navbar-collapse .close-label | |
| 69 { | |
| 70 display: none; | |
| 71 } | |
| 72 | |
| 73 .expanded .toggle-navbar-collapse .open-label | |
| 74 { | |
| 75 display: none; | |
| 76 } | |
| 77 | |
| 78 .expanded .toggle-navbar-collapse .close-label | |
| 79 { | |
| 80 display: inline; | |
| 81 } | |
| 82 | |
| 83 /* .navbar .navbar-collapse | |
|
juliandoucette
2017/11/10 11:42:53
Suggest: Add padding/space to the <a> themselves i
juliandoucette
2017/11/10 11:42:53
Suggest: Add an active/hover/focus background colo
ire
2017/11/13 17:57:40
Do we want them to look more like buttons? I know
ire
2017/11/13 17:57:42
Same as previously answer. background-color applie
| |
| 84 ****************************************************************************/ | |
| 85 | |
| 86 .navbar-collapse | |
| 87 { | |
| 88 clear: both; | |
| 89 padding-top: 0; | |
| 90 | |
| 91 @media (min-width: $tablet-breakpoint) | |
| 92 { | |
| 93 float: right; | |
| 94 clear: none; | |
| 95 padding-top: $navbar-padding-v + ($navbar-padding-v / 2); | |
| 96 } | |
| 97 } | |
| 98 | |
| 99 [dir="rtl"] .navbar-collapse | |
| 100 { | |
| 101 float: left; | |
| 102 } | |
| 103 | |
| 104 .js .navbar-collapse | |
| 105 { | |
| 106 display: none; | |
| 107 | |
| 108 @media (min-width: $tablet-breakpoint) | |
| 109 { | |
| 110 display: block; | |
| 111 } | |
| 112 } | |
| 113 | |
| 114 .expanded .navbar-collapse | |
| 115 { | |
| 116 display: block; | |
| 117 } | |
| 118 | |
| 119 /* .navbar .nav | |
|
juliandoucette
2017/11/10 11:42:52
NIT/Suggest: Make the whole line and space above/b
| |
| 120 ****************************************************************************/ | |
| 121 | |
| 122 .navbar .nav li | |
| 123 { | |
| 124 margin-bottom: $navbar-padding-v; | |
| 125 | |
| 126 @media (min-width: $tablet-breakpoint) | |
| 127 { | |
| 128 display: inline-block; | |
| 129 margin: 0 0 0 $navbar-padding-v; | |
| 130 } | |
| 131 } | |
| 132 | |
| 133 [dir="rtl"] .navbar .nav li | |
| 134 { | |
| 135 @media (min-width: $tablet-breakpoint) | |
| 136 { | |
| 137 display: inline-block; | |
| 138 margin: 0 $navbar-padding-v 0 0; | |
| 139 } | |
| 140 } | |
| 141 | |
| 142 .navbar .nav li:last-child | |
| 143 { | |
| 144 margin-bottom: 0; | |
| 145 } | |
| OLD | NEW |