includes/components/navbar.html - Issue 29587584: Issue 5635 - Implement website-default navbar component

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: includes/components/navbar.html

Issue 29587584: Issue 5635 - Implement website-default navbar component (Closed) Base URL: https://hg.adblockplus.org/website-defaults

Patch Set: Addressed NITs Created Nov. 13, 2017, 5:19 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

OLD	NEW
(Empty)
	1 <div class="navbar bg-primary">

	2 <div class="container">

	3 <a href="index" class="navbar-branding float-start">

	4 <img src="/img/png/eyeo-logo.png" srcset="/img/svg/eyeo-logo.svg 2x" alt=" eyeo">

	5 </a>

	6

	7 <button class="toggle-navbar-collapse float-end">
	juliandoucette 2017/11/15 12:56:42 NIT: It seems inconsistent that you use .float-end NIT: It seems inconsistent that you use .float-end here and not below for navbar-nav/navbar-collapse. ire 2017/11/30 14:01:18 The reason I did this was because, for the .navbar Show quoted text On 2017/11/15 12:56:42, juliandoucette wrote: > NIT: It seems inconsistent that you use .float-end here and not below for > navbar-nav/navbar-collapse. The reason I did this was because, for the .navbar-nav, it changes based on screen size. So it's only .float-end on desktop.
	8 <span class="open-label">Open</span>

	9 <span class="sr-only">/</span>

	10 <span class="close-label">Close</span>

	11 Menu

	12 </button>

	13

	14 <nav class="navbar-nav navbar-collapse">

	15 <ul>

	16 <li><a href="index">Navbar Menu Link</a></li>

	17 <li><a href="index">Navbar Menu Link</a></li>

	18 <li><a href="index">Navbar Menu Link</a></li>

	19 <li><a href="index">Navbar Menu Link</a></li>

	20 </ul>

	21 </nav>

	22 </div>

	23 </div>

OLD	NEW

« no previous file with comments | « no previous file | pages/index.html » ('j') | static/js/navbar.js » ('J')