Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: includes/components/navbar.html

Issue 29587584: Issue 5635 - Implement website-default navbar component (Closed) Base URL: https://hg.adblockplus.org/website-defaults
Left Patch Set: Rebased Created Oct. 31, 2017, 2:07 p.m.
Right Patch Set: Rebase Created Jan. 4, 2018, 7:40 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « no previous file | pages/index.html » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 <div class="navbar"> 1 <div class="navbar bg-primary">
2 <div class="container"> 2 <div class="navbar-container">
3 <h1 class="navbar-branding"> 3 <a href="index" class="navbar-branding float-start">
juliandoucette 2017/10/31 15:18:37 I don't know whether it's better to let the site t
juliandoucette 2017/10/31 15:30:44 AFAICT page heading should be <h1> and navbar bran
ire 2017/11/02 11:15:25 I think you're right. I haven't found a documented
4 <a href="index">Website Defaults</a> 4 <img src="/img/png/eyeo-logo.png" srcset="/img/svg/eyeo-logo.svg 2x" alt=" eyeo">
5 </h1> 5 </a>
6 6
7 <button class="toggle-navbar-collapse"> 7 <button class="toggle-navbar-collapse button-link float-end">
8 <span class="open-label">Open</span> 8 Toggle Menu
9 <span class="sr-only">/</span>
10 <span class="close-label">Close</span>
11 Menu
12 </button> 9 </button>
13 10
14 <div class="navbar-collapse"> 11 <nav class="navbar-nav navbar-collapse">
15 <nav> 12 <ul>
16 <a href="index">Navbar Menu Link</a> 13 <li><a href="index">Navbar Menu Link</a></li>
17 </nav> 14 <li><a href="index">Navbar Menu Link</a></li>
18 </div> 15 <li><a href="index">Navbar Menu Link</a></li>
16 <li><a href="index">Navbar Menu Link</a></li>
17 </ul>
18 </nav>
19 </div> 19 </div>
20 </div> 20 </div>
LEFTRIGHT
« no previous file | pages/index.html » ('j') | Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Toggle Comments ('s')

Powered by Google App Engine
This is Rietveld