includes/components/navbar.html - Issue 29587584: Issue 5635 - Implement website-default navbar component

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: includes/components/navbar.html

Issue 29587584: Issue 5635 - Implement website-default navbar component (Closed) Base URL: https://hg.adblockplus.org/website-defaults

Left Patch Set: Rebased Created Oct. 31, 2017, 2:07 p.m.

Right Patch Set: Rebase Created Jan. 4, 2018, 7:40 a.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 <div class="navbar">	1 <div class="navbar bg-primary">

2 <div class="container">	2 <div class="navbar-container">

3 <h1 class="navbar-branding">	3 <a href="index" class="navbar-branding float-start">
juliandoucette 2017/10/31 15:18:37 I don't know whether it's better to let the site t I don't know whether it's better to let the site title be h1 or the page heading be h1 these days. Have we discussed this before? / Have you looked into this lately? juliandoucette 2017/10/31 15:30:44 AFAICT page heading should be <h1> and navbar bran Show quoted text On 2017/10/31 15:18:37, juliandoucette wrote: > I don't know whether it's better to let the site title be h1 or the page heading > be h1 these days. Have we discussed this before? / Have you looked into this > lately? AFAICT page heading should be <h1> and navbar brand should be <a>. But I haven't found a reliable source. ire 2017/11/02 11:15:25 I think you're right. I haven't found a documented Show quoted text On 2017/10/31 15:30:44, juliandoucette wrote: > On 2017/10/31 15:18:37, juliandoucette wrote: > > I don't know whether it's better to let the site title be h1 or the page > heading > > be h1 these days. Have we discussed this before? / Have you looked into this > > lately? > > AFAICT page heading should be <h1> and navbar brand should be <a>. But I haven't > found a reliable source. I think you're right. I haven't found a documented source either, but I spoke to a friend of mine who's an accessibility expert about it and he says <h1> should describe the unique content of the page.
4 <a href="index">Website Defaults</a>	4 <img src="/img/png/eyeo-logo.png" srcset="/img/svg/eyeo-logo.svg 2x" alt=" eyeo">

5 </h1>	5 </a>

6	6

7 <button class="toggle-navbar-collapse">	7 <button class="toggle-navbar-collapse button-link float-end">

8 <span class="open-label">Open</span>	8 Toggle Menu

9 <span class="sr-only">/</span>

10 <span class="close-label">Close</span>

11 Menu

12 </button>	9 </button>

13	10

14 <div class="navbar-collapse">	11 <nav class="navbar-nav navbar-collapse">

15 <nav>	12 <ul>

16 <a href="index">Navbar Menu Link</a>	13 <li><a href="index">Navbar Menu Link</a></li>

17 </nav>	14 <li><a href="index">Navbar Menu Link</a></li>

18 </div>	15 <li><a href="index">Navbar Menu Link</a></li>

	16 <li><a href="index">Navbar Menu Link</a></li>

	17 </ul>

	18 </nav>

19 </div>	19 </div>

20 </div>	20 </div>

LEFT	RIGHT