includes/components/navbar.html - Issue 29587584: Issue 5635 - Implement website-default navbar component

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: includes/components/navbar.html

Issue 29587584: Issue 5635 - Implement website-default navbar component (Closed) Base URL: https://hg.adblockplus.org/website-defaults

Left Patch Set: Demo - Use table layout Created Nov. 2, 2017, 11:08 a.m.

Right Patch Set: Rebase Created Jan. 4, 2018, 7:40 a.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 <div class="navbar bg-primary">	1 <div class="navbar bg-primary">

2 <div class="container">	2 <div class="navbar-container">

3 <a href="index" class="navbar-branding text-start">Website<br> Defaults</a>	3 <a href="index" class="navbar-branding float-start">
ire 2017/11/02 11:15:28 I added this line break to simulate the height of I added this line break to simulate the height of a logo being different from the menu juliandoucette 2017/11/02 13:31:22 Acknowledged. Show quoted text On 2017/11/02 11:15:28, ire wrote: > I added this line break to simulate the height of a logo being different from > the menu Acknowledged.
	4 <img src="/img/png/eyeo-logo.png" srcset="/img/svg/eyeo-logo.svg 2x" alt=" eyeo">

	5 </a>

4	6

5 <div class="toggle-navbar-collapse text-end">	7 <button class="toggle-navbar-collapse button-link float-end">
ire 2017/11/02 11:15:28 Had to add a container because display: table-cell Had to add a container because display: table-cell doesn't work on buttons juliandoucette 2017/11/02 13:31:22 Acknowledged. Show quoted text On 2017/11/02 11:15:28, ire wrote: > Had to add a container because display: table-cell doesn't work on buttons Acknowledged.
6 <button>	8 Toggle Menu

7 <span class="open-label">Open</span>	9 </button>

8 <span class="sr-only">/</span>

9 <span class="close-label">Close</span>

10 Menu

11 </button>

12 </div>

13	10

14 <div class="navbar-collapse">	11 <nav class="navbar-nav navbar-collapse">

15 <nav>	12 <ul>

16 <a href="index">Navbar Menu Link</a>, <a href="index">Navbar Menu Link</ a>, <a href="index">Navbar Menu Link</a>, <a href="index">Navbar Menu Link</a>	13 <li><a href="index">Navbar Menu Link</a></li>
ire 2017/11/02 11:15:28 Added more links for testing, even though I know i Added more links for testing, even though I know it won't ever look like this. I will change in later patch juliandoucette 2017/11/02 13:31:23 Acknowledged. Show quoted text On 2017/11/02 11:15:28, ire wrote: > Added more links for testing, even though I know it won't ever look like this. I > will change in later patch Acknowledged.
17 </nav>	14 <li><a href="index">Navbar Menu Link</a></li>

18 </div>	15 <li><a href="index">Navbar Menu Link</a></li>

	16 <li><a href="index">Navbar Menu Link</a></li>

	17 </ul>

	18 </nav>

19 </div>	19 </div>

20 </div>	20 </div>

LEFT	RIGHT